Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add headless mode #3439

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Add headless mode #3439

wants to merge 3 commits into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Dec 26, 2021 •
edited
Loading

Objective

In this PR I added the ability to opt-out graphical backends. Closes #3155.

Solution

I turned backends into Option and removed panicking sub app API to force users handle the error (was suggested by @cart).

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 26, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible and removed S-Needs-Triage This issue needs to be labelled labels Dec 26, 2021
bjorn3
bjorn3 reviewed Dec 26, 2021
View reviewed changes
crates/bevy_app/src/app.rs Outdated Show resolved Hide resolved
@cart cart added this to the Bevy 0.6 milestone Dec 31, 2021
@cart cart removed this from the Bevy 0.6 milestone Jan 8, 2022
@cart
Copy link
Member

cart commented Jan 8, 2022

This breaks examples like 3d_scene because it tries registering ImagePlugin before the RenderApp is inserted

@Shatur
Copy link
Contributor Author

Shatur commented Jan 8, 2022 •
edited
Loading

This breaks examples like 3d_scene because it tries registering ImagePlugin before the RenderApp is inserted

Yeah, thinking about elegant solution right now. The function is huge.

@cart
Copy link
Member

cart commented Jan 8, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jan 8, 2022
@Shatur
Add headless mode (#3439)
458cb7a 
# Objective

In this PR I added the ability to opt-out graphical backends. Closes #3155.

## Solution

I turned backends into `Option` ~~and removed panicking sub app API to force users handle the error (was suggested by `@cart`)~~.
@bors
Copy link
Contributor

bors bot commented Jan 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add headless mode [Merged by Bors] - Add headless mode Jan 8, 2022
@bors bors bot closed this Jan 8, 2022
@Shatur Shatur mentioned this pull request Jan 8, 2022
Merged
@bjorn3 bjorn3 mentioned this pull request Jan 23, 2022
Closed
@DJMcNab DJMcNab mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add headless renderer
4 participants
@Shatur @cart @bjorn3 @alice-i-cecile