Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headless_defaults example displays an empty window #5260

Closed
LegNeato opened this issue Jul 9, 2022 · 3 comments
Closed

headless_defaults example displays an empty window #5260

LegNeato opened this issue Jul 9, 2022 · 3 comments
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled

Comments

@LegNeato
Copy link
Contributor

LegNeato commented Jul 9, 2022 •
edited
Loading

Bevy version

518408dfdaa8884ba86a71512de2a7d57848413d

What you did

Run cargo run --example headless_defaults

What went wrong

It isn't headless...a window is displayed:
Screen Shot 2022-07-09 at 1 32 30 PM

I expected no window to be displayed.
@LegNeato LegNeato added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 9, 2022
LegNeato added a commit to LegNeato/bevy that referenced this issue Jul 9, 2022
@LegNeato
Make headless_defaults example actually headless
1263382 
Fixes bevyengine#5260
@LegNeato LegNeato mentioned this issue Jul 9, 2022
Closed
@DJMcNab
Copy link
Member

DJMcNab commented Jul 9, 2022

The examples readme says that the example is:

An application that runs with default plugins, but without an actual renderer.

The purpose of the example is to test that everything works if no wgpu backends are set, which is required because

This issue and the other comment (#3155 (comment)) suggests that people are struggling to understand this example, so it could probably do with a rename - maybe no_renderer?
As far as I can tell, there was no discussion of this in #3439 - @Shatur do you have any thoughts on the name?

@Shatur
Copy link
Contributor

Shatur commented Jul 9, 2022

so it could probably do with a rename - maybe no_renderer

Yes, it makes more sense. And I think we also should note in the example description that the window will be present.

@LegNeato
Copy link
Contributor Author

LegNeato commented Jul 9, 2022

Cool, will do.

LegNeato added a commit to LegNeato/bevy that referenced this issue Jul 9, 2022
@LegNeato
Rename headless_defaults example to no_renderer for clarity
2964855 
Fixes bevyengine#5260.
@LegNeato LegNeato mentioned this issue Jul 9, 2022
Closed
LegNeato added a commit to LegNeato/bevy that referenced this issue Jul 10, 2022
@LegNeato
Rename headless_defaults example to no_renderer for clarity
ea1d6ef 
Fixes bevyengine#5260.
@bors bors bot closed this as completed in 2344ada Jul 11, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this issue Aug 8, 2022
@LegNeato @inodentry
Rename headless_defaults example to no_renderer for clarity (bevy…
292388f 
…engine#5263)

# Objective

- Reduce confusion as the example opens a window and isn't truly "headless"
- Fixes bevyengine#5260.


## Solution

- Rename the example and add to the docs that the window is expected.
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@LegNeato @james7132
Rename headless_defaults example to no_renderer for clarity (bevy…
d2e3e15 
…engine#5263)

# Objective

- Reduce confusion as the example opens a window and isn't truly "headless"
- Fixes bevyengine#5260.


## Solution

- Rename the example and add to the docs that the window is expected.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@LegNeato @ItsDoot
Rename headless_defaults example to no_renderer for clarity (bevy…
d0012d7 
…engine#5263)

# Objective

- Reduce confusion as the example opens a window and isn't truly "headless"
- Fixes bevyengine#5260.


## Solution

- Rename the example and add to the docs that the window is expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled
Projects
None yet
Milestone
No milestone
3 participants
@LegNeato @Shatur @DJMcNab