Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - remove Events from bevy_app, they now live in bevy_ecs #4066

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - remove Events from bevy_app, they now live in bevy_ecs #4066

wants to merge 1 commit into from

Conversation

pubrrr
Copy link
Contributor

@pubrrr pubrrr commented Feb 28, 2022

Objective

Fixes #4064.

Solution

  • remove Events from bevy_app

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 28, 2022
alice-i-cecile
alice-i-cecile approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for tackling this! All of the changes LGTM, and thanks for the first contribution.

@alice-i-cecile alice-i-cecile added A-App Bevy apps and plugins A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Feb 28, 2022
@alice-i-cecile
Copy link
Member

Ah, looks like you ended up missing at least one behind a feature flag. Check the CI run, it'll show you where it is.

@mockersf
Copy link
Member

mockersf commented Mar 1, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 1, 2022
@pubrrr
remove Events from bevy_app, they now live in bevy_ecs (#4066)
caf6611 
# Objective

Fixes #4064.

## Solution

- remove Events from bevy_app
@bors
Copy link
Contributor

bors bot commented Mar 1, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title remove Events from bevy_app, they now live in bevy_ecs [Merged by Bors] - remove Events from bevy_app, they now live in bevy_ecs Mar 1, 2022
@bors bors bot closed this Mar 1, 2022
@pubrrr pubrrr deleted the removeEventsFromApp branch March 1, 2022 21:54
kurtkuehnert pushed a commit to kurtkuehnert/bevy that referenced this pull request Mar 6, 2022
@pubrrr
remove Events from bevy_app, they now live in bevy_ecs (bevyengine#4066)
05fbc04 
# Objective

Fixes bevyengine#4064.

## Solution

- remove Events from bevy_app
@ramirezmike ramirezmike mentioned this pull request Apr 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@kirusfg kirusfg kirusfg approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Events from bevy_app
4 participants
@pubrrr @alice-i-cecile @mockersf @kirusfg