Make headless_defaults example actually headless
#5261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
suggested changes
Jul 9, 2022
There was a problem hiding this comment.
I don't really like this change - it misses that the point of the example is to test running a complete bevy application without the renderer, and to ensure we support that. This capability would be useful if alternative renderers are being used.
I'm not quite sure on the reason for the headless mode existing aside from just disabling the render feature (although testing it would require more set-up)
|
The example is not what one would commonly consider headless...so perhaps the change here is to rename it if the behavior is intended? |
LegNeato
force-pushed
the
headless_example
branch
from
bed8336
to
7e2222d
Compare
|
Abandoning this in favor of renaming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5260