Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - remove an unused import in release #5320

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - remove an unused import in release #5320

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jul 14, 2022 •
edited
Loading

Objective

  • There is a warning when building in release:
warning: unused import: `Local`
 --> crates/bevy_render/src/extract_resource.rs:4:34
  |
4 | use bevy_ecs::system::{Commands, Local, Res, ResMut, Resource};
  |                                  ^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Solution

  • Gate the import

@mockersf mockersf added the C-Code-Quality A section of code that is hard to understand or change label Jul 14, 2022
superdump
superdump approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Jul 14, 2022
@mockersf
remove an unused import in release (#5320)
44566db 
# Objective

- There is a warning when building in release:
```
warning: unused import: `Local`
 --> crates/bevy_render/src/extract_resource.rs:4:34
  |
4 | use bevy_ecs::system::{Commands, Local, Res, ResMut, Resource};
  |                                  ^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/814f8d1635587ad26d9e1e6e08e7d63b4355f4d7/crates/bevy_render/src/extract_resource.rs#L45
- Fix it

## Solution

- Gate the import
@bors
Copy link
Contributor

bors bot commented Jul 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title remove an unused import in release [Merged by Bors] - remove an unused import in release Jul 14, 2022
@bors bors bot closed this Jul 14, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@mockersf @inodentry
remove an unused import in release (bevyengine#5320)
d464a8d 
# Objective

- There is a warning when building in release:
```
warning: unused import: `Local`
 --> crates/bevy_render/src/extract_resource.rs:4:34
  |
4 | use bevy_ecs::system::{Commands, Local, Res, ResMut, Resource};
  |                                  ^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/814f8d1635587ad26d9e1e6e08e7d63b4355f4d7/crates/bevy_render/src/extract_resource.rs#L45
- Fix it

## Solution

- Gate the import
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
remove an unused import in release (bevyengine#5320)
79fcfd8 
# Objective

- There is a warning when building in release:
```
warning: unused import: `Local`
 --> crates/bevy_render/src/extract_resource.rs:4:34
  |
4 | use bevy_ecs::system::{Commands, Local, Res, ResMut, Resource};
  |                                  ^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/814f8d1635587ad26d9e1e6e08e7d63b4355f4d7/crates/bevy_render/src/extract_resource.rs#L45
- Fix it

## Solution

- Gate the import
@mockersf mockersf mentioned this pull request Jan 11, 2023
Closed
bors bot pushed a commit that referenced this pull request Jan 11, 2023
@mockersf
gate an import used only for a debug assert (#7165)
aa3dd14 
# Objective

- There is a warning when building in release:
```
warning: unused import: `bevy_ecs::system::Local`
 --> crates/bevy_render/src/extract_resource.rs:5:5
  |
5 | use bevy_ecs::system::Local;
  |     ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47
- Fix it

## Solution

- Gate the import
- repeat of #5320
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@mockersf @alradish
gate an import used only for a debug assert (bevyengine#7165)
a77d614 
# Objective

- There is a warning when building in release:
```
warning: unused import: `bevy_ecs::system::Local`
 --> crates/bevy_render/src/extract_resource.rs:5:5
  |
5 | use bevy_ecs::system::Local;
  |     ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47
- Fix it

## Solution

- Gate the import
- repeat of bevyengine#5320
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
remove an unused import in release (bevyengine#5320)
eb64eef 
# Objective

- There is a warning when building in release:
```
warning: unused import: `Local`
 --> crates/bevy_render/src/extract_resource.rs:4:34
  |
4 | use bevy_ecs::system::{Commands, Local, Res, ResMut, Resource};
  |                                  ^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/814f8d1635587ad26d9e1e6e08e7d63b4355f4d7/crates/bevy_render/src/extract_resource.rs#L45
- Fix it

## Solution

- Gate the import
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
gate an import used only for a debug assert (bevyengine#7165)
cebd21a 
# Objective

- There is a warning when building in release:
```
warning: unused import: `bevy_ecs::system::Local`
 --> crates/bevy_render/src/extract_resource.rs:5:5
  |
5 | use bevy_ecs::system::Local;
  |     ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47
- Fix it

## Solution

- Gate the import
- repeat of bevyengine#5320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@IceSentry IceSentry IceSentry approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @superdump @IceSentry @tim-blackbird