[Merged by Bors] - gate an import used only for a debug assert #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
the
C-Code-Quality
james7132
approved these changes
Jan 11, 2023
MinerSebas
approved these changes
Jan 11, 2023
IceSentry
approved these changes
Jan 11, 2023
james7132
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
# Objective - There is a warning when building in release: ``` warning: unused import: `bevy_ecs::system::Local` --> crates/bevy_render/src/extract_resource.rs:5:5 | 5 | use bevy_ecs::system::Local; | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default ``` - It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47 - Fix it ## Solution - Gate the import - repeat of #5320
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - There is a warning when building in release: ``` warning: unused import: `bevy_ecs::system::Local` --> crates/bevy_render/src/extract_resource.rs:5:5 | 5 | use bevy_ecs::system::Local; | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default ``` - It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47 - Fix it ## Solution - Gate the import - repeat of bevyengine#5320
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - There is a warning when building in release: ``` warning: unused import: `bevy_ecs::system::Local` --> crates/bevy_render/src/extract_resource.rs:5:5 | 5 | use bevy_ecs::system::Local; | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default ``` - It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47 - Fix it ## Solution - Gate the import - repeat of bevyengine#5320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy/crates/bevy_render/src/extract_resource.rs
Line 47 in 59751d6
Solution