[Merged by Bors] - Add default implementation of Serialize and Deserialize to Timer and Stopwatch #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
Yes, this is important state that will need to be e.g. transferred across the network.
No, this isn't used in that example, so should not be done to avoid distracting readers. |
alice-i-cecile
approved these changes
Oct 13, 2022
|
Ping @bzm3r for a review. |
mockersf
approved these changes
Oct 13, 2022
mockersf
added
the
S-Ready-For-Final-Review
bzm3r
approved these changes
Oct 13, 2022
|
It's probably worth mentioning that when #6247 is merged, implementations for |
|
#6247 is getting merged, so I'm holding off on this for a sec. @SleepySwords can you add that impl to this PR when you get a second? Once that's done I'll merge this PR ASAP. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
…Stopwatch (#6248) # Objective Fixes #6244 ## Solution Uses derive to implement `Serialize` and `Deserialize` for `Timer` and `Stopwatch` ### Things to consider - Should fields such as `finished` and `times_finished_this_tick` in `Timer` be serialized? - Does `Countdown` and `PrintOnCompletionTimer` need to be serialized and deserialized? ## Changelog Added `Serialize` and `Deserialize` implementations to `Timer` and `Stopwatch`, `Countdown`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…Stopwatch (bevyengine#6248) # Objective Fixes bevyengine#6244 ## Solution Uses derive to implement `Serialize` and `Deserialize` for `Timer` and `Stopwatch` ### Things to consider - Should fields such as `finished` and `times_finished_this_tick` in `Timer` be serialized? - Does `Countdown` and `PrintOnCompletionTimer` need to be serialized and deserialized? ## Changelog Added `Serialize` and `Deserialize` implementations to `Timer` and `Stopwatch`, `Countdown`.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…Stopwatch (bevyengine#6248) # Objective Fixes bevyengine#6244 ## Solution Uses derive to implement `Serialize` and `Deserialize` for `Timer` and `Stopwatch` ### Things to consider - Should fields such as `finished` and `times_finished_this_tick` in `Timer` be serialized? - Does `Countdown` and `PrintOnCompletionTimer` need to be serialized and deserialized? ## Changelog Added `Serialize` and `Deserialize` implementations to `Timer` and `Stopwatch`, `Countdown`.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
…Stopwatch (bevyengine#6248) # Objective Fixes bevyengine#6244 ## Solution Uses derive to implement `Serialize` and `Deserialize` for `Timer` and `Stopwatch` ### Things to consider - Should fields such as `finished` and `times_finished_this_tick` in `Timer` be serialized? - Does `Countdown` and `PrintOnCompletionTimer` need to be serialized and deserialized? ## Changelog Added `Serialize` and `Deserialize` implementations to `Timer` and `Stopwatch`, `Countdown`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…Stopwatch (bevyengine#6248) # Objective Fixes bevyengine#6244 ## Solution Uses derive to implement `Serialize` and `Deserialize` for `Timer` and `Stopwatch` ### Things to consider - Should fields such as `finished` and `times_finished_this_tick` in `Timer` be serialized? - Does `Countdown` and `PrintOnCompletionTimer` need to be serialized and deserialized? ## Changelog Added `Serialize` and `Deserialize` implementations to `Timer` and `Stopwatch`, `Countdown`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #6244
Solution
Uses derive to implement
SerializeandDeserializeforTimerandStopwatchThings to consider
finishedandtimes_finished_this_tickinTimerbe serialized?CountdownandPrintOnCompletionTimerneed to be serialized and deserialized?Changelog
Added
SerializeandDeserializeimplementations toTimerandStopwatch,Countdown.