[Merged by Bors] - Constify SpritePipelineKey implementation. #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-Rendering
james7132
approved these changes
Dec 19, 2022
hymm
reviewed
Dec 19, 2022
crates/bevy_sprite/src/render/mod.rs
Outdated
| Self::from_bits(msaa_bits).unwrap() | ||
| // SAFETY: The input is the correct type and the mask will ensure the output range is | ||
| // capped | ||
| unsafe { Self::from_bits_unchecked(msaa_bits) } |
There was a problem hiding this comment.
For other reviewers here's the safety comment from the bitflags crate
https://docs.rs/bitflags/latest/src/bitflags/lib.rs.html#575-577
/// The caller of `from_bits_unchecked()` has to ensure that
/// all bits correspond to a defined flag or that extra bits
/// are valid for this bitflags type.
hymm
approved these changes
Dec 19, 2022
james7132
added
the
S-Ready-For-Final-Review
cart
reviewed
Dec 20, 2022
crates/bevy_sprite/src/render/mod.rs
Outdated
| Self::from_bits(msaa_bits).unwrap() | ||
| // SAFETY: The input is the correct type and the mask will ensure the output range is | ||
| // capped | ||
| unsafe { Self::from_bits_unchecked(msaa_bits) } |
There was a problem hiding this comment.
Idk if this is a good enough reason to introduce unsafe code. Does const-ing this unlock specific scenarios we need? Are there performance benefits (that we have measured)?
There was a problem hiding this comment.
Suggested change
| unsafe { Self::from_bits_unchecked(msaa_bits) } | |
| Self::from_bits_truncate(msaa_bits) |
This should be const and safe.
There was a problem hiding this comment.
Thanks, I overlooked that, will fix it shortly.
…s_unchecked in order to be const.
james7132
approved these changes
Dec 22, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective - Describe the objective or issue this PR addresses. SpritePipelineKey could use more constification. ## Solution Constify SpritePipelineKey implementation. ## Changelog Co-authored-by: AxiomaticSemantics <117950168+AxiomaticSemantics@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective - Describe the objective or issue this PR addresses. SpritePipelineKey could use more constification. ## Solution Constify SpritePipelineKey implementation. ## Changelog Co-authored-by: AxiomaticSemantics <117950168+AxiomaticSemantics@users.noreply.github.com>
bors
bot
changed the title
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - Describe the objective or issue this PR addresses. SpritePipelineKey could use more constification. ## Solution Constify SpritePipelineKey implementation. ## Changelog Co-authored-by: AxiomaticSemantics <117950168+AxiomaticSemantics@users.noreply.github.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Describe the objective or issue this PR addresses. SpritePipelineKey could use more constification. ## Solution Constify SpritePipelineKey implementation. ## Changelog Co-authored-by: AxiomaticSemantics <117950168+AxiomaticSemantics@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
SpritePipelineKey could use more constification.
Solution
Constify SpritePipelineKey implementation.
Changelog