Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow builders to guard out of map #3969

Merged

Conversation

saurtron
Copy link
Collaborator

@saurtron saurtron commented Nov 24, 2024

Work done

  • Add rule to only allow builders to guard other units out of map.

Addresses Issue(s)

This doesn't fix the issue directly, but once engine version with out of map leniency hits it will be fixed, this PR addresses concerns at the issue of avoiding aircraft guard hacks out of map.

out of map leniency is removing restrictions on out of map guard and attack (except for ground attack).

Test steps

  • Make an aircraft builder build something close to the edge.
  • Wait until it's out of map.
  • Set some other unit, like another air con to guard it.

Remarks

  • This goes in unit_prevent_aircraft_hax.lua. It does affect other units since for example construction turrets can help airplanes too. It's all about preventing aircraft hacks so I think it's ok.
  • This only will really have an effect with latest engine version, but it won't hurt if run with an older (like current) version, it will just enforce something the engine is also enforcing itself.

@saurtron saurtron changed the title Only builders guard out of map Onlya allow builders to guard out of map Nov 24, 2024
@saurtron saurtron changed the title Onlya allow builders to guard out of map Only allow builders to guard out of map Nov 24, 2024
@WatchTheFort WatchTheFort merged commit 38c5745 into beyond-all-reason:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants