Out of map orders leniency

[saurtron]

Work Done

• Allow centering area commands out of map.
• Allow attacking out of map units.
• Allow guarding out of map units when both the actor and guardee are builders.

Related issues

• Constuction aircraft cannot be assisted if aircraft outside of map Beyond-All-Reason#763

Remarks

• I think these actions are safe and wanted, since not being easy to target out of map units with attacks incentivises out of map attack hacks. Regarding the guard issue it's in the above referenced issue.
• Could have maybe touched some more orders but for now these seem the most pressing.
• Still doesn't allow attack ground out of map (in case someone is wondering).
• Also allowing any out of map unit to issue guard orders, don't see why we shouldn't allow this.

[sprunk]

This is for a game to decide. IMO either keep the limit as-is or remove wholesale, don't instate a different limit. In general that applies to every command whose limitation isn't for technical reasons.

[saurtron]

ok, just did it like this because it's what ppl requested at beyond-all-reason/Beyond-All-Reason#763 but we can just remove the check here and then make it stricter in some lua gadget.

[saurtron]

Ok removed the check here and prepared a PR for BAR doing the same check.

[sprunk]

A bunch of other commands (capture, repair etc) still check bounds, perhaps if guard loses the restriction then they all should?

[saurtron]

A bunch of other commands (capture, repair etc) still check bounds, perhaps if guard loses the restriction then they all should?

Maybe, since nobody asked for that I didn't want to lift too many restrictions at the same time. Some of these might need further checks in games to avoid hacks, like with out of map guard command.

That said, I'm open to removing further checks if you deem it necessary.

[sprunk]

Looks good.