fix: various patches to formatting (#171)

bgd-labs · Oct 26, 2024 · 62387e6 · 62387e6
1 parent 31497e5
commit 62387e6
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/src/govv3/checks/state.ts b/src/govv3/checks/state.ts
@@ -259,7 +259,7 @@ async function enhanceValue({
       if (asset) return prettifyNumber({decimals: asset.decimals, value, showDecimals: true});
     }
     // values to be rendered with ray decimals
-    if (key && ['_reserves'].includes(type)) {
+    if (key && ['_reserves', '_eModeCategories'].includes(type)) {
       if (['liquidityIndex', 'variableBorrowIndex'].includes(key))
         return prettifyNumber({decimals: 27, value, showDecimals: true});
       if (['liquidationThreshold', 'reserveFactor', 'liquidationProtocolFee'].includes(key))
@@ -270,6 +270,14 @@ async function enhanceValue({
         )
       )
         return prettifyNumber({decimals: 25, value, suffix: '%', showDecimals: true});
+      if (['liquidationBonus'].includes(key))
+        return prettifyNumber({
+          decimals: 2,
+          value,
+          suffix: '%',
+          showDecimals: true,
+          patchedValue: BigInt(value) - BigInt(1e4),
+        });
     }
   }
   return value;

diff --git a/src/govv3/utils/markdownUtils.ts b/src/govv3/utils/markdownUtils.ts
@@ -75,15 +75,19 @@ export function prettifyNumber({
   prefix,
   suffix,
   showDecimals,
+  patchedValue,
 }: {
   value: string | number | bigint;
   decimals: number;
   prefix?: string;
   suffix?: string;
   showDecimals?: boolean;
+  // allow overwriting the value when formatting
+  // this is useful for e.g. 1e4 % numbers, when the 100% should be removed in the formatting
+  patchedValue?: string | number | bigint;
 }) {
   const formattedNumber = limitDecimalsWithoutRounding(
-    formatNumberString(formatUnits(BigInt(value), decimals)),
+    formatNumberString(formatUnits(BigInt(patchedValue || value), decimals)),
     4,
   );
   return `${prefix ? `${prefix} ` : ''}${formattedNumber}${

diff --git a/src/reports/diff-reports.ts b/src/reports/diff-reports.ts
@@ -102,8 +102,7 @@ export async function diffReports<A extends AaveV3Snapshot, B extends AaveV3Snap
           pre,
           post,
         );
-        // when it doesn't have changes it means the eMode is new
-      } else {
+      } else if (!pre.eModes[eMode] || !post.eModes[eMode]) {
         content += renderEmodeDiff(
           diff(pre.eModes[eMode] || {}, post.eModes[eMode] || {}) as any,
           pre,