-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] fix links, make json object links consistent, fix pandoc rendering #587
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4c2b68f
fix links to JSON objects
sappelhoff 46d65fa
convert faulty footnote to normal text
sappelhoff 56443bb
change markdown comment syntax -> HTML comment syntax
sappelhoff c0eea0f
consistent links to JSON object specification
sappelhoff 06c9ea0
fix link syntax
sappelhoff 9b1ae95
should -> SHOULD, ref: https://github.com/bids-standard/bids-specific…
sappelhoff 8cc75cf
Apply suggestions from code review
sappelhoff db79a98
fix typos
sappelhoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,10 +69,10 @@ In addition to the keys for raw BIDS datasets, | |
derived BIDS datasets include the following REQUIRED and RECOMMENDED | ||
`dataset_description.json` keys: | ||
|
||
| **Key name** | **Description** | | ||
| -------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| GeneratedBy | REQUIRED. List of [objects][object] with at least one element. | | ||
| SourceDatasets | RECOMMENDED. A list of [objects][object] specifying the locations and relevant attributes of all source datasets. Valid fields in each object include `URL`, `DOI`, and `Version`. | | ||
| **Key name** | **Description** | | ||
| -------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| GeneratedBy | REQUIRED. List of [objects][] with at least one element. | | ||
| SourceDatasets | RECOMMENDED. A list of [objects][] specifying the locations and relevant attributes of all source datasets. Valid fields in each object include `URL`, `DOI`, and `Version`. | | ||
|
||
Each object in the `GeneratedBy` list includes the following REQUIRED, RECOMMENDED | ||
and OPTIONAL keys: | ||
|
@@ -83,7 +83,7 @@ and OPTIONAL keys: | |
| Version | RECOMMENDED. Version of the pipeline. | | ||
| Description | OPTIONAL. Plain-text description of the pipeline or process that generated the outputs. RECOMMENDED if `Name` is `"Manual"`. | | ||
| CodeURL | OPTIONAL. URL where the code used to generate the derivatives may be found. | | ||
| Container | OPTIONAL. [Object][object] specifying the location and relevant attributes of software container image used to produce the derivative. Valid fields in this object include `Type`, `Tag` and `URI`. | | ||
| Container | OPTIONAL. [Object][] specifying the location and relevant attributes of software container image used to produce the derivative. Valid fields in this object include `Type`, `Tag` and `URI`. | | ||
|
||
Example: | ||
|
||
|
@@ -344,7 +344,7 @@ For anonymization purposes all dates within one subject should be shifted by a | |
randomly chosen (but consistent across all runs etc.) number of days. | ||
This way relative timing would be preserved, but chances of identifying a | ||
person based on the date and time of their scan would be decreased. | ||
Dates that are shifted for anonymization purposes should be set to a year 1925 | ||
Dates that are shifted for anonymization purposes SHOULD be set to the year 1925 | ||
or earlier to clearly distinguish them from unmodified data. | ||
Shifting dates is RECOMMENDED, but not required. | ||
|
||
|
@@ -368,12 +368,16 @@ func/sub-control01_task-motor_bold.nii.gz 1877-06-15T13:55:33 | |
|
||
Template: `code/*` | ||
|
||
Source code of scripts that were used to prepare the dataset (for example if it | ||
was anonymized or defaced) MAY be stored here.<sup>1</sup> Extra care should be | ||
taken to avoid including original IDs or any identifiable information with the | ||
source code. There are no limitations or recommendations on the language and/or | ||
Source code of scripts that were used to prepare the dataset MAY be stored here. | ||
Examples include anonymization or defacing of the data, or | ||
the conversion from the format of the source data to the BIDS format | ||
(see [source vs. raw vs. derived data](./02-common-principles.md#source-vs-raw-vs-derived-data)). | ||
Extra care should be taken to avoid including original IDs or | ||
any identifiable information with the source code. | ||
There are no limitations or recommendations on the language and/or | ||
code organization of these scripts at the moment. | ||
|
||
<sup>1</sup>Storing actual source files with the data is preferred over links to | ||
external source repositories to maximize long term preservation (which would | ||
suffer if an external repository would not be available anymore). | ||
Comment on lines
-377
to
-379
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these lines are now in the and as you can see above, the |
||
<!-- Link Definitions --> | ||
|
||
[objects]: https://www.json.org/json-en.html | ||
[object]: https://www.json.org/json-en.html |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These sentences come from the
code
section. Thecode
section now contains a link to this section instead.see: #587 (comment)