[FIX] Clarify run indexing information for MRI acquisitions #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlevitas
changed the title
sappelhoff
reviewed
Dec 9, 2020
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
Outdated
Show resolved
Hide resolved
…ata.md Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
effigies
reviewed
Dec 12, 2020
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
Outdated
Show resolved
Hide resolved
effigies
reviewed
Jan 4, 2021
Comment on lines
168
to
170
| If several scans of the same modality are acquired they MUST be indexed with the | ||
| [`run-<index>`](../99-appendices/09-entities.md#run) key-value pair: | ||
| `_run-1`, `_run-2`, `_run-3`, and so on (only nonnegative integers are allowed as |
There was a problem hiding this comment.
Suggested change
| If several scans of the same modality are acquired they MUST be indexed with the | |
| [`run-<index>`](../99-appendices/09-entities.md#run) key-value pair: | |
| `_run-1`, `_run-2`, `_run-3`, and so on (only nonnegative integers are allowed as |
| run labels). When there is only one scan of a given type the run key MAY be | ||
| omitted. Please note that diffusion imaging data is stored elsewhere (see | ||
| below). | ||
| run labels). |
There was a problem hiding this comment.
Suggested change
| run labels). |
tsalo
reviewed
Jan 4, 2021
Comment on lines
+177
to
+180
| If different entities apply, | ||
| such as a different session indicated by [`ses-<label>`](../99-appendices/09-entities.md#ses), | ||
| or different acquisition parameters indicated by [`acq-<label>`](../99-appendices/09-entities.md#acq), | ||
| then `run` is not needed to distinguish the scans and MAY be omitted. |
There was a problem hiding this comment.
I think this is crucial information that should be reflected in the run entity definition, rather than in a specific modality's section.
|
Closing in favor of #719. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fix, regarding this NeuroStars issue