-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add transformation free model #26
Conversation
Reading the data descriptor paper, found some GLM description for the task data, that is also in there. Could be interesting for FSL users who use FLOBS
|
This is also an interesting case because the events.tsv in there have no trial_type: only onset and duration |
Nice, looks good to me. I would say let's not close #11 though. I'd like to add an example that is transformation free and also event related. |
@effigies @adelavega |
"subject" | ||
], | ||
"Model": { | ||
"Description": "removes effect of 1) realigment parameters, their squares, their derivatives and the derivatives squared and 2) the mean signal measured in CSF, white matter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some "comments": I believe we should make extensive / intensive use of them in the model zoo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have ds002799 added twice as submodules. The model names have hyphens instead of underscores. I might suggest the following:
model-denoise_desc-compcor_smdl.json
model-denoise_desc-scrubbing_smdl.json
model-denoise_desc-simple_smdl.json
Finally, your code editor seems to be omitting or removing trailing newlines, which is counter to standard practice (see https://thoughtbot.com/blog/no-newline-at-end-of-file). Would you be willing to update your config?
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
…into resting_stage
related to #11
uses stats model to implement 3 different noising strategies on resting state data
inspired by nilearn's : https://nilearn.github.io/stable/modules/generated/nilearn.interfaces.fmriprep.load_confounds_strategy.html
TODO:
Could possibly still use transformation to create other scrubbing regressors, but probably best to keep this simple