Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] update packaging #27

Merged
merged 9 commits into from
May 29, 2023
Merged

[MAINT] update packaging #27

merged 9 commits into from
May 29, 2023

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented May 23, 2023

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: +22.33 🎉

Comparison is base (9f1e7b9) 70.62% compared to head (5a4015f) 92.96%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #27       +/-   ##
===========================================
+ Coverage   70.62%   92.96%   +22.33%     
===========================================
  Files          12       12               
  Lines         858      554      -304     
===========================================
- Hits          606      515       -91     
+ Misses        252       39      -213     
Impacted Files Coverage Δ
bids/ext/reports/report.py 92.85% <81.81%> (ø)
bids/ext/reports/utils.py 90.90% <83.33%> (ø)
bids/ext/reports/parsing.py 93.05% <88.88%> (+0.40%) ⬆️
bids/ext/reports/parameters.py 92.14% <92.85%> (+0.23%) ⬆️
bids/ext/reports/__init__.py 100.00% <100.00%> (ø)
bids/ext/reports/due.py 68.00% <100.00%> (ø)
bids/ext/reports/templates.py 93.54% <100.00%> (+3.54%) ⬆️
bids/ext/reports/tests/conftest.py 86.66% <100.00%> (ø)
bids/ext/reports/tests/test_parsing.py 100.00% <100.00%> (ø)
bids/ext/reports/tests/test_report.py 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Remi-Gau
Copy link
Contributor Author

Can the whole content of setup.cfg be moved to pyproject.toml?

@Remi-Gau
Copy link
Contributor Author

@effigies

seems that subpackaging still works using setuptools: which I remember you said was not possible anymore.

if you suggest that we use hatch instead (or something else), will it still be possible to use versioneer?

if you some time could check this PR?
more specifically:

  • does the packaging setup look sensible to you?
  • can what's left in the setup.cfg be transferred in the pyproject.toml?
  • there seems to be a duplication or purpose with what's in the MANIFEST.in and what is package data in the setup.cfg

recursive-include bids/ext/reports/config *.json

setup.cfg: ⬇️

[options.package_data]
* =
    config/*

@Remi-Gau
Copy link
Contributor Author

@tsalo
merging this

FYI packaging is now done with hatch.

@Remi-Gau Remi-Gau merged commit 594b59c into bids-standard:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow git submodule with mustache templates to be used as package data Package Import is not possible.
1 participant