Skip to content

Commit

Permalink
Merge pull request #1278 from Ubersmake/STRF-5007
Browse files Browse the repository at this point in the history
Disable zoom and link for default "No Image" image.
  • Loading branch information
Ubersmake authored Jun 19, 2018
2 parents f74f5de + 2aa17d3 commit 584c782
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Add alias for lazysizes module to bundle minified library [#1275](https://github.com/bigcommerce/cornerstone/pull/1275)
- Fix prices not showing in quick search while logged in when "Restrict to Login" for price display is true [#1272](https://github.com/bigcommerce/cornerstone/pull/1272)
- Display product reviews in tabbed content region of product page [#1273](https://github.com/bigcommerce/cornerstone/pull/1273)
- Disable zoom and link for default "No Image" image. [#1278](https://github.com/bigcommerce/cornerstone/pull/1278)

## 2.1.0 (2018-06-01)
- Add Newsletter summary section to subscription form. [#1248](https://github.com/bigcommerce/cornerstone/pull/1248)
Expand Down
24 changes: 15 additions & 9 deletions templates/components/products/product-view.html
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,23 @@ <h2 class="productView-brand"{{#if schema}} itemprop="brand" itemscope itemtype=

<section class="productView-images" data-image-gallery>
<figure class="productView-image"
data-image-gallery-main
data-zoom-image="{{getImage product.main_image 'zoom_size' (cdn theme_settings.default_image_product)}}"
{{#if product.main_image}}
data-image-gallery-main
data-zoom-image="{{getImage product.main_image 'zoom_size' (cdn theme_settings.default_image_product)}}"
{{/if}}
>
<div class="productView-img-container">
<a href="{{getImage product.main_image 'zoom_size' (cdn theme_settings.default_image_product)}}">
<img class="productView-image--default lazyload"
data-sizes="auto"
src="{{cdn 'img/loading.svg'}}"
data-src="{{getImage product.main_image 'product_size' (cdn theme_settings.default_image_product)}}"
alt="{{product.main_image.alt}}" title="{{product.main_image.alt}}" data-main-image>
</a>
{{#if product.main_image}}
<a href="{{getImage product.main_image 'zoom_size' (cdn theme_settings.default_image_product)}}">
<img class="productView-image--default lazyload"
data-sizes="auto"
src="{{cdn 'img/loading.svg'}}"
data-src="{{getImage product.main_image 'product_size' (cdn theme_settings.default_image_product)}}"
alt="{{product.main_image.alt}}" title="{{product.main_image.alt}}" data-main-image>
</a>
{{else}}
<img class="productView-image--default" src="{{cdn theme_settings.default_image_product}}">
{{/if}}
</div>
</figure>
<ul class="productView-thumbnails"{{#gt product.images.length 5}} data-slick='{
Expand Down

0 comments on commit 584c782

Please sign in to comment.