Disable zoom and link for default "No Image" image. #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
reviewed
Jun 19, 2018
| data-src="{{getImage product.main_image 'product_size' (cdn theme_settings.default_image_product)}}" | ||
| alt="{{product.main_image.alt}}" title="{{product.main_image.alt}}" data-main-image> | ||
| </a> | ||
| {{else}} | ||
| <img class="productView-image--default" src="{{cdn theme_settings.default_image_product}}"> |
There was a problem hiding this comment.
spacing is off .. it should be 1 level deep.
junedkazi
reviewed
Jun 19, 2018
| > | ||
| <div class="productView-img-container"> | ||
| {{#if product.main_image}} |
There was a problem hiding this comment.
Same spacing here .. move the content 1 level inside.
junedkazi
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a product has no images Cornerstone will display a default "No Image" image.
This image is zoomable, like other product images. And clicking on the image (if you can manage to click the 0x0 element) will open the full-size version of the image in the current view.
This PR removes that behavior. If a product has no images and thus displays the "No Image" image, the "No Image" image is treated like placeholder text. It does not zoom. It has no link.
Tickets / Documentation
Screenshots (if appropriate)
Before
Product Details Page:
Quick View:
After
Product Details Page:
Quick View: