Skip to content

Commit

Permalink
Merge pull request #1341 from jake-bc/STRF-5396
Browse files Browse the repository at this point in the history
Countries with symbols & punctuation in the name are not encoding
  • Loading branch information
junedkazi authored Sep 5, 2018
2 parents f3434e5 + b1d5a67 commit 72e2cc7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
## Draft
- Fix encoding issues on Account Signup Form ("'" characters showing in country name)[#1341] (https://github.com/bigcommerce/cornerstone/pull/1341)
- Require Webpack config only when used (reduce time to be ready for receiving messages from stencil-cli). [#1334](https://github.com/bigcommerce/cornerstone/pull/1334)

## 2.3.2 (2018-08-17)
Expand Down
16 changes: 9 additions & 7 deletions templates/components/common/forms/select.html
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
<div class="form-field" id="{{id}}" data-validation="{{validation}}" {{#if private_id}}data-type="{{private_id}}"{{/if}} >
<div class="form-field" id="{{id}}" data-validation="{{validation}}" {{#if private_id}} data-type="{{private_id}}"
{{/if}}>
<label class="form-label" for="{{id}}_select">{{label}}
{{#if required}}<small>{{lang 'common.required' }}</small>{{/if}}
</label>
<select class="{{class}} form-select" id="{{id}}_select" data-label="{{label}}" aria-required="{{required}}" name="{{name}}"{{#if private_id}}data-field-type="{{private_id}}"{{/if}}>
<select class="{{class}} form-select" id="{{id}}_select" data-label="{{label}}" aria-required="{{required}}" name="{{name}}"
{{#if private_id}} data-field-type="{{private_id}}" {{/if}}>
{{#if options}}
<option value="">{{chooseprefix}}</option>
{{#each options}}
<option {{#if selected}} selected {{/if}}value="{{value}}">{{label}}</option>
{{/each}}
<option value="">{{chooseprefix}}</option>
{{#each options}}
<option {{#if selected}} selected {{/if}} value="{{value}}">{{{label}}}</option>
{{/each}}
{{/if}}
</select>
</div>
</div>

0 comments on commit 72e2cc7

Please sign in to comment.