fix(storefront): STENCIL-3567 Fix spaces in faceted search option names #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
For stores that implement faceted search on category and search pages, the list of filters can be limited to a specific number with the rest revealed after a 'show more' link is clicked. When the name of the filter or facet contains a space, the
show morelink does not work.This fix uses the
hypenateHandlebars filter to remove spaces before the facet name is applied as a DOM selector.Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
@bigcommerce/stencil-team