Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): STENCIL-3567 Fix spaces in faceted search option names #1113

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

tabayomi
Copy link

@tabayomi tabayomi commented Nov 1, 2017

What?

For stores that implement faceted search on category and search pages, the list of filters can be limited to a specific number with the rest revealed after a 'show more' link is clicked. When the name of the filter or facet contains a space, the show more link does not work.

This fix uses the hypenate Handlebars filter to remove spaces before the facet name is applied as a DOM selector.

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

facet-name-hyphen

@bigcommerce/stencil-team

Copy link
Contributor

@mjschock mjschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabayomi tabayomi merged commit e07592e into bigcommerce:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants