Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): STENCIL-3567 Fix spaces in faceted search option names #1113

Merged
merged 1 commit into from
Nov 3, 2017
Merged

fix(storefront): STENCIL-3567 Fix spaces in faceted search option names #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions templates/components/faceted-search/facets/hierarchy.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div
class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
role="button"
data-collapsible="#facetedSearch-content--{{ facet }}">
data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
<h5 class="accordion-title">
{{ title }}
</h5>
Expand All @@ -21,12 +21,12 @@ <h5 class="accordion-title">
</div>
</div>

<div id="facetedSearch-content--{{ facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
<ul id="facetedSearch-navList--{{ facet }}" class="navList" data-facet="{{facet}}" data-has-more-results="{{ has_more_results }}">
<div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
<ul id="facetedSearch-navList--{{hyphenate facet }}" class="navList" data-facet="{{facet}}" data-has-more-results="{{ has_more_results }}">
{{#each items}}
<li class="navList-item">
<a
href="{{url}}"
href="{{ url }}"
class="navList-action navList-action--checkbox {{#if selected }} is-selected {{/if}} {{#if has_sub_categories }} has-children {{/if}}"
rel="nofollow"
data-id="{{ id }}"
Expand All @@ -46,7 +46,7 @@ <h5 class="accordion-title">
</ul>

{{#if show_more_toggle}}
<a href="#facetedSearch-navList--{{ facet }}" role="button" class="toggleLink">
<a href="#facetedSearch-navList--{{hyphenate facet }}" role="button" class="toggleLink">
<span class="toggleLink-text toggleLink-text--off">{{lang 'search.faceted.show-more'}}</span>
</a>
{{/if}}
Expand Down
8 changes: 4 additions & 4 deletions templates/components/faceted-search/facets/multi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div
class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
role="button"
data-collapsible="#facetedSearch-content--{{ facet }}">
data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
<h5 class="accordion-title">
{{ title }}
</h5>
Expand All @@ -21,8 +21,8 @@ <h5 class="accordion-title">
</div>
</div>

<div id="facetedSearch-content--{{ facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
<ul id="facetedSearch-navList--{{ facet }}" data-facet="{{facet}}" class="navList" data-has-more-results="{{ has_more_results }}">
<div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
<ul id="facetedSearch-navList--{{hyphenate facet }}" data-facet="{{facet}}" class="navList" data-has-more-results="{{ has_more_results }}">
{{#each items}}
<li class="navList-item">
<a
Expand All @@ -46,7 +46,7 @@ <h5 class="accordion-title">
</ul>

{{#if show_more_toggle}}
<a href="#facetedSearch-navList--{{ facet }}" role="button" class="toggleLink">
<a href="#facetedSearch-navList--{{hyphenate facet }}" role="button" class="toggleLink">
<span class="toggleLink-text toggleLink-text--off">{{lang 'search.faceted.show-more'}}</span>
</a>
{{/if}}
Expand Down
4 changes: 2 additions & 2 deletions templates/components/faceted-search/facets/range.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div
class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
role="button"
data-collapsible="#facetedSearch-content--{{ facet }}">
data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
<h5 class="accordion-title">
{{ title }}
</h5>
Expand All @@ -20,7 +20,7 @@ <h5 class="accordion-title">
</div>
</div>

<div id="facetedSearch-content--{{ facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
<div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
<form id="facet-range-form" class="form" method="get" data-faceted-search-range novalidate>
{{#each current_selected_items}}
<input type="hidden" name="{{ param_name }}[]" value="{{ param_value }}"/>
Expand Down
4 changes: 2 additions & 2 deletions templates/components/faceted-search/facets/rating.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div
class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
role="button"
data-collapsible="#facetedSearch-content--{{ facet }}">
data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
<h5 class="accordion-title">
{{ title }}
</h5>
Expand All @@ -21,7 +21,7 @@ <h5 class="accordion-title">
</div>
</div>

<div id="facetedSearch-content--{{ facet }}" class="accordion-content facetedSearch-content--{{ facet }} {{#unless ../start_collapsed }} is-open {{/unless}}">
<div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content facetedSearch-content--{{hyphenate facet}} {{#unless ../start_collapsed }} is-open {{/unless}}">
<ul class="navList">
{{#each items}}
<li class="navList-item">
Expand Down