Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #1273 #1281

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Revert #1273 #1281

merged 1 commit into from
Jun 21, 2018

Conversation

Ubersmake
Copy link
Contributor

What?

Revert "Display product reviews in tabbed content region of product page:" #1273

This is pretty awesome and needs to be revisited, but will not make it into 2.2.0. Current issues are:

  • Default behavior has changed for non-tabbed reviews. Reviews should be hidden by default when opening a product page.
  • When reviews are tabbed, they still have the "Hide Reviews" option, which is unnecessary in this configuration.

Tickets / Documentation

@bigbot
Copy link

bigbot commented Jun 21, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@Ubersmake Ubersmake changed the title Revert https://github.com/bigcommerce/cornerstone/pull/1273 Revert #1273 Jun 21, 2018
@Ubersmake Ubersmake merged commit 07805e4 into bigcommerce:master Jun 21, 2018
@Ubersmake Ubersmake deleted the Revert-1273 branch June 21, 2018 19:29
@sacr3dc0w sacr3dc0w mentioned this pull request Jun 22, 2018
Closed
@Ubersmake Ubersmake mentioned this pull request Jul 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpietsch tpietsch tpietsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ubersmake @bigbot @tpietsch