Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display product reviews in tabbed content region of product page #1282

Closed
wants to merge 1 commit into from
Closed

Display product reviews in tabbed content region of product page #1282

wants to merge 1 commit into from

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Jun 22, 2018

What?

Adds an option to display customer reviews in the details tabs area on product pages.

This PR builds off #1273 by addressing the issues in #1281 that required a revert for the original commit.

Tickets / Documentation

Screenshots

False, Full Width, top of product page - tab region
false 01 full top
False, Full Width, collapsed (default)
false 02 full bottom
False, Desktop, expanded
false 03 desktop
False, Tablet, expanded
false 04 tablet
False, Mobile, expanded
false 05 mobile
True, Full Width
true 01 full
True, Desktop
true 02 desktop
True, Tablet
true 03 tablet
True, Mobile
true 04 mobile
Theme Editor
screen shot 2018-06-21 at 5 44 44 pm

@bigbot
Copy link

bigbot commented Jun 22, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@junedkazi
Copy link
Contributor

Thank you @sacr3dc0w for getting on top of this one. We will get this PR reviewed but it will not be merged till 2.2 goes out next week.

@junedkazi
Copy link
Contributor

@Ubersmake can we test these changes before we merge them to make sure all our tests are passing.

@sacr3dc0w sacr3dc0w closed this Jul 12, 2018
@sacr3dc0w sacr3dc0w deleted the review-tabs branch July 12, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants