Disable zoom and link for default "No Image" image. #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A revert of the revert (#1279) of #1278. There are some slight changes between
product-view.htmlin this and #1278, with the goal of this PR to keep as much information on the rendered page as possible.The vast majority of this description is copied over from #1278.
When a product has no images Cornerstone will display a default "No Image" image.
This image is zoomable, like other product images. And the image technically exists within an element.
This PR removes that behavior. If a product has no images and thus displays the "No Image" image, the "No Image" image is treated like placeholder text. It does not zoom. It has no
href.As a caveat, it is possible for a product to have no image, but for its variants to have images. In this specific case the zoom behavior is removed from both the "No Image" image and any images associated with variants. There is no workaround for this at this time.
Products with images with some but not all variants with images were never affected.
Diff for
product-view.htmlbetween this PR and the commit in #1278: DiffTickets / Documentation
Screenshots (if appropriate)
Before
Product Details Page:
Quick View:
Product Details Page, No Main Image, One Variant with Image:
After
Product Details Page:
Quick View:
Product Details Page, No Main Image, One Variant with Image: