-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update payment methods list and edit page to show all stored instruments #1603
Conversation
Autotagging @bigcommerce/storefront-team @davidchin |
f092f45
to
a141a20
Compare
N.B. this should not be merged in until the backend work to fulfil the new object payload has been completed. |
33a668b
to
35360c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to increase the space between payment method sections (ex. between Credit Card section and Paypal section). I suggest changing margin-top
to 2rem
instead of 0 in .paymentMethodName
class in _paymentMethods.scss
@leeBigCommerce |
27b0c2b
to
0ea9f3d
Compare
0ea9f3d
to
e2ff4d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @leeBigCommerce. Got minor some minor questions below.
Thanks @leeBigCommerce. All LGTM now 👍 |
@leeBigCommerce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leeBigCommerce
In the new release, we need to create another copy of american_express.svg named amex.svg to handle this issue:
https://jira.bigcommerce.com/browse/STRF-7869
https://jira.bigcommerce.com/browse/STRF-7869 will be dealt with in a seperate ticket and PR |
caa4b22
to
14b473e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@leeBigCommerce I approved it but it requires approval of someone with write access. |
14b473e
to
54f5681
Compare
While this is likely not the appropriate place for this comment, but are you aware of the massive amount of credit card verification attacks that are occurring on this Payment methods page in BigCommerce? With the ability to simply add Payment methods like this to your Vault (PayPal/Braintree), hackers use this functionality and script out the action of adding payment methods with their lists of stolen credit cards, and use it to verify things like zip code, cvv, etc. The card won't be stored to the vault and added to Payment methods list, unless it is verified by the payment processor first. So they use their scripts to just keep trying add cards using different CVVs, zip codes, etc. until it is verified and added. This way, they can verify large lists of stolen credit cards, and use it to figure out the CVV or zip code if they don't have it. A group of hackers were trying to verify over 30,000+ credit cards a day on my Bigcommerce store using this functionality and BigCommerce has no way to protect against this. I was forced to disable the form submit button to prevent this from occurring. Can you consider implementing a recaptcha to protect against this? The native Bigcommerce recaptchas don't protect this area of the store, only things like contact forms, review forms, login, and checkout. |
What?
The current payment_methods object within my account is only built to support stored credit cards. Now that we have the option to store PayPal accounts (and likely more in the future)
Tickets / Documentation
Screenshots (if appropriate)