Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] update edit saved payment page to allow for PayPal instruments #1604

Closed

Conversation

leeBigCommerce
Copy link
Contributor

What?

To allow users to edit their newly save-able PayPal instruments

Tickets / Documentation

Screenshots (if appropriate)

@bigbot
Copy link

bigbot commented Nov 27, 2019

Autotagging @bigcommerce/storefront-team @davidchin

@leeBigCommerce
Copy link
Contributor Author

Dependant on work to fulfil the new "account_payment_methods_v2" feature

@Tharaae
Copy link
Contributor

Tharaae commented Jan 2, 2020

@leeBigCommerce Isn't this PR is now already included the previous one #1603? If so, please close this PR.

<label class="form-label" for="default_instrument">{{lang 'forms.payment_methods.default_instrument'}}</label>
</div>
</div>
{{#with customer.payment_methods.selected_payment_method}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is not right. Should #1603 takes precedence?

@leeBigCommerce
Copy link
Contributor Author

Superseded by #1603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants