feature(storefront): STRF-8629 Update cli to use template engine based on the value stored in config.json #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
changed the title
…d on the value stored in config.json
jairo-bc
changed the title
junedkazi
reviewed
Sep 1, 2020
| @@ -43,6 +43,7 @@ | |||
| "last 2 versions", | |||
| "Firefox ESR" | |||
| ], | |||
| "template_engine": "handlebars_v3", | |||
There was a problem hiding this comment.
we should update this to v4
|
closing this in favor of #1834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d on the value stored in config.json
What?
Added to the config.json template_engine variable which determines which template engine to use. By default it's handlebars v3.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Attach images or add image links here.