feat(storefront): STRF-8630 update cornerstone to be compatible with handlebars v4 #1834
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
| default_image=../../theme_settings.default_image_product | ||
| fallback_size=../theme_settings.productthumb_size | ||
| lazyload=../theme_settings.lazyload_mode | ||
| default_image=../theme_settings.default_image_product |
There was a problem hiding this comment.
Does @root work in v4? It might make for cleaner syntax if we just did @root.theme_settings.default_image_product for example.
There was a problem hiding this comment.
Didn't check, will take a look.
There was a problem hiding this comment.
Just checked this, for some reason @root is undefined for v3 and v4.
Mostly manually. Took a look at all occurrences of the I think after stencil-cli is released with newer version I will be able to run functional tests on integration. Does it take specific version or the latest master? @junedkazi |
|
@junedkazi @mattolson Added to the description findings from the testings |
|
@jairo-bc this need a rebase |
What?
Updated cornerstone theme to be compatible with the handlebars v4. Most changes are applied due to changed logic in the calculating
../and=character is now HTML escaped.https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md#v400---september-1st-2015
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-8626
https://jira.bigcommerce.com/browse/STRF-8630
How it was tested?
Several times tried to do that using functional tests. Couldn't get a case, when the tests weren't failing. I've got, that latest master(e1270850b1b083d762b339e57096b2c06be53ef3) and these changes have same amount errors(except 1 case on master). Links I'm able to provide in private