fix: STRF-9873 use modified copies of get, getObject, moment, option 3p helpers
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
reviewed
Jun 15, 2022
helpers/get.js
Outdated
| return; | ||
| } | ||
|
|
||
| let value = _.get(context, path); |
There was a problem hiding this comment.
If it possible not to bring dependency on lodash, it would be ideal. We have a ticket in backlog to remove that dependency.
bc-evan-johnson
force-pushed
the
STRF-9873
branch
from
2c36273 to
f24a534
Compare
jairo-bc
previously approved these changes
Jun 16, 2022
…option` 3p helpers
bc-evan-johnson
force-pushed
the
STRF-9873
branch
from
f24a534 to
528d07a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Bring a subset of 3rd-party helpers into our codebase with some modifications.
Internal details at https://bigcommercecloud.atlassian.net/browse/STRF-9873
How was it tested?
Unit tests + interactive testing in CDVM.
cc @bigcommerce/storefront-team