fix: STRF 9873 make get etc. compatible with concat return value
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
reviewed
Jun 20, 2022
| @@ -10,21 +10,21 @@ function isValidURL(val) { | |||
| } | |||
|
|
|||
| /* | |||
| * Based on https://github.com/jonschlinkert/get-value/blob/3.0.1/index.js, but | |||
There was a problem hiding this comment.
What was the intend to update this library? Looks like 2.0.6 is the current version in handlebars helpers.
Did you check if there are any breaking changes in behaviour?
There was a problem hiding this comment.
Updating that library unfortunately wouldn't solve all our problems. We'd still need to unwrap SafeStrings, for example, as well as adding checks in getObject.
bc-evan-johnson
force-pushed
the
STRF-9873-patch
branch
from
d5a979f to
ffe758c
Compare
…tring-key behavior
bc-evan-johnson
force-pushed
the
STRF-9873-patch
branch
from
2149982 to
a2374b7
Compare
jairo-bc
approved these changes
Jun 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
#171 inadvertently broke an edge case where the
concathelper is used to dynamically generate property paths.With the original
getandoptionhelpers, this only worked with top-level properties (not nested properties) due to an implicittoStringconversion here. This PR modifies those helpers to accept both top-level and nested property paths generated byconcat.Edit: During testing & review, I noticed that the old
gethelper would retrieve empty string keys (get({'': 0}, '')would return0) and have made changes to match that behavior.How was it tested?
Unit tests have been added to cover cases where
concatis used to generate property paths for helpers modified in #171.cc @bigcommerce/storefront-team