feat(merc): MERC-9364 Use CDN Original images for webdav - cache control #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchu93
force-pushed
the
MERC-9364
branch
2 times, most recently
from
69c2c47 to
c5c2ed4
Compare
This was referenced Jul 15, 2023
jairo-bc
previously approved these changes
Jul 17, 2023
|
Rebased! |
jkanive
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Use CDN Original images for webdav - cache control.
If a developer/merchant decide to use the handlebar to import images from WebDav into the theme
({{cdn "webdav:/img/image.jpg"}}), there is no cache-control header when the image is presented to the storefront.Similar to our Image Manager, we should be using the cdn original images (Similar to Jinsoo's PR here MERC-7127
Example images:
Original /content/
Updated /images/stencil/original/content/
How was it tested?
Tested locally
cc @bigcommerce/storefront-team