Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merc): Bump paper version #1125

Closed
wants to merge 1 commit into from
Closed

Conversation

kchu93
Copy link
Contributor

@kchu93 kchu93 commented Jul 17, 2023

What? Why?

Use CDN Original images for webdav - cache control.

If a developer/merchant decide to use the handlebar to import images from WebDav into the theme ({{cdn "webdav:/img/image.jpg"}}), there is no cache-control header when the image is presented to the storefront.

Similar to our Image Manager, we should be using the cdn original images (Similar to Jinsoo's PR here MERC-7127

Example images:
Original /content/

Updated /images/stencil/original/content/

How was it tested?

Tested locally

cc @bigcommerce/storefront-team

@jairo-bc
Copy link
Contributor

Take a look at this comment: bigcommerce/paper#343 (comment)

@kchu93 kchu93 closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants