Merge pull request #645 from MaxGenash/STRF-8625_Update_stencil_cli_t…

…o_support_node_12 feat: (strf-8625) support Node 12.x
bigcommerce · Sep 23, 2020 · af6204b · af6204b
2 parents 6a6b3a1 + 1449751
commit af6204b
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 5 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v10.16.3
+v12.18.4
diff --git a/.travis.yml b/.travis.yml
@@ -6,7 +6,8 @@ addons:
   ssh_known_hosts:
     - github.com
 node_js:
-  - 10
+  - 10.22.1
+  - 12.18.4
 
 cache:
   directories:

diff --git a/README.md b/README.md
@@ -7,7 +7,9 @@
 The BigCommerce server emulator for local theme development.
 
 ## Install
-_Note: Stencil requires the Node.js runtime environment, version 10.x We do not yet have support for Node 12 or greater._
+_Note: Stencil requires the Node.js runtime environment,
+version 10.x and 12.x (Recommended) are supported.
+We do not yet have support for versions greater than Node 12._
 
 Run `npm install -g @bigcommerce/stencil-cli`.
 

diff --git a/appveyor.yml b/appveyor.yml
@@ -1,6 +1,7 @@
 environment:
   matrix:
     - nodejs_version: "10"
+    - nodejs_version: "12"
 platform:
   - x86
   - x64

diff --git a/lib/version-check.js b/lib/version-check.js
@@ -5,7 +5,7 @@ module.exports = function () {
     const satisfies = semver.satisfies(process.versions.node, PACKAGE_INFO.engines.node);
 
     if (!satisfies) {
-        console.error('You are running an older version of node. Please upgrade to ' + PACKAGE_INFO.engines.node);
+        console.error('You are running an unsupported version of node. Please upgrade to ' + PACKAGE_INFO.engines.node);
     }
 
     return satisfies;

diff --git a/package.json b/package.json
@@ -4,7 +4,7 @@
   "description": "CLI tool to run BigCommerce Stores locally for theme development.",
   "main": "index.js",
   "engines": {
-    "node": ">= 10.0.0 <11.0.0"
+    "node": "^10 || ^12"
   },
   "scripts": {
     "lint": "eslint .",