feat: (strf-8625) support Node 12.x #645
Conversation
| @@ -6,7 +6,7 @@ addons: | |||
| ssh_known_hosts: | |||
| - github.com | |||
| node_js: | |||
| - 10 | |||
There was a problem hiding this comment.
I wonder if we should support 10 as well until EOL for node 10 or should we switch over support to 12 only
@bookernath thoughts ?
There was a problem hiding this comment.
We should take into account that there are some dependencies (esp. related to hapi) that have last versions already not supporting node 10
There was a problem hiding this comment.
Decided that we should support node 10 too
There was a problem hiding this comment.
@MaxGenash lets keep node 10 for now since it is an LTS version. We will drop it next year.
There was a problem hiding this comment.
Ok.
@junedkazi also just for curiosity tried node 14, but unfortunately, our old version of node-sass doesn’t work with it :(
There was a problem hiding this comment.
yes since we are on a forked version of node-sass we have not compiled a node 14 binary for it.
| @@ -6,7 +6,7 @@ addons: | |||
| ssh_known_hosts: | |||
| - github.com | |||
| node_js: | |||
| - 10 | |||
| - 12.18.4 | |||
There was a problem hiding this comment.
We also need to update appveyor
Line 3 in e0b6387
There was a problem hiding this comment.
I did it, it should be visible in https://github.com/bigcommerce/stencil-cli/pull/645/files
|
@junedkazi we should also update the documentation to reflect the latest version. Actually instead of we can write it will grab the correct version from .nvmrc automatically |
Yeah, I did it |
MaxGenash
force-pushed
the
STRF-8625_Update_stencil_cli_to_support_node_12
branch
from
6b5d63f to
176741c
Compare
MaxGenash
force-pushed
the
STRF-8625_Update_stencil_cli_to_support_node_12
branch
from
176741c to
80861b5
Compare
README.md
Outdated
| _Note: Stencil requires the Node.js runtime environment, version 10.x We do not yet have support for Node 12 or greater._ | ||
| _Note: Stencil requires the **Node.js** runtime environment, version **12.x** (recommended), | ||
| or 10.x (still supported, but will be removed soon). | ||
| We do not ensure correct work on other versions at the moment._ |
There was a problem hiding this comment.
I don't think we need this line.
README.md
Outdated
| _Note: Stencil requires the **Node.js** runtime environment, version **12.x** (recommended), | ||
| or 10.x (still supported, but will be removed soon). |
There was a problem hiding this comment.
How about we change this to
_Note: Stencil requires the Node.js runtime environment, version 10.x and 12.x (Recommended) are supported. We do not yet have support for versions greater than Node 12._
80861b5 to
1449751
Compare
What?
Added support for node 12.x.
Smoke-tested all the CLI commands + ran local store, seems to work fine.
Tickets / Documentation
strf-8625