Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (strf-8625) support Node 12.x #645

Merged
merged 1 commit into from
Sep 23, 2020
Merged

feat: (strf-8625) support Node 12.x #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v10.16.3
v12.18.4
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ addons:
ssh_known_hosts:
- github.com
node_js:
- 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should support 10 as well until EOL for node 10 or should we switch over support to 12 only
@bookernath thoughts ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take into account that there are some dependencies (esp. related to hapi) that have last versions already not supporting node 10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided that we should support node 10 too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxGenash lets keep node 10 for now since it is an LTS version. We will drop it next year.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
@junedkazi also just for curiosity tried node 14, but unfortunately, our old version of node-sass doesn’t work with it :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes since we are on a forked version of node-sass we have not compiled a node 14 binary for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, got it

- 10.22.1
- 12.18.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update appveyor

stencil-cli/appveyor.yml

Line 3 in e0b6387

- nodejs_version: "10"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it, it should be visible in https://github.com/bigcommerce/stencil-cli/pull/645/files


cache:
directories:
Expand Down
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
The BigCommerce server emulator for local theme development.

## Install
_Note: Stencil requires the Node.js runtime environment, version 10.x We do not yet have support for Node 12 or greater._
_Note: Stencil requires the Node.js runtime environment,
version 10.x and 12.x (Recommended) are supported.
We do not yet have support for versions greater than Node 12._

Run `npm install -g @bigcommerce/stencil-cli`.

Expand Down
1 change: 1 addition & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
environment:
matrix:
- nodejs_version: "10"
- nodejs_version: "12"
platform:
- x86
- x64
Expand Down
2 changes: 1 addition & 1 deletion lib/version-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = function () {
const satisfies = semver.satisfies(process.versions.node, PACKAGE_INFO.engines.node);

if (!satisfies) {
console.error('You are running an older version of node. Please upgrade to ' + PACKAGE_INFO.engines.node);
console.error('You are running an unsupported version of node. Please upgrade to ' + PACKAGE_INFO.engines.node);
}

return satisfies;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "CLI tool to run BigCommerce Stores locally for theme development.",
"main": "index.js",
"engines": {
"node": ">= 10.0.0 <11.0.0"
"node": "^10 || ^12"
},
"scripts": {
"lint": "eslint .",
Expand Down