-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #165 by displaying an info box if WebGL is not detected #186
Conversation
Build results will soon be (or already are) available at: http://ci.qiime.org/job/emperor-github-pr/114/ |
Thanks for adding this, this is exactly one of the things that we needed the most! I think this should not show the sidebar and in turn should only show a white background with this message at the center. It would also make sense to add a small explanation of what is happening, something along the lines of: "Emperor's visualization framework is WebGL based, it seems that your system doesn't have this resource available ... etc ". Some suggestions:
|
An extra addition to this is to mention that if you are using chrome and still not seeing an image, go to |
…lso updated to include a logo and more text.
Build results will soon be (or already are) available at: http://ci.qiime.org/job/emperor-github-pr/122/ |
Woooow! This looks really pretty!!! Thanks much @jacksonchen. Just a couple suggestions:
After this, it should be ready to merge. |
Thanks for the feedback! I added your suggestions and here is the commit. Hopefully it is in the final form to be merged, thanks! |
Build results will soon be (or already are) available at: http://ci.qiime.org/job/emperor-github-pr/123/ |
Hello @jacksonchen I think this is it. @antgonza suggested I tested this on IE, it of course didn't work and the error message was presented, so this is working great! The two things that I'm going to suggest are to:
If people is curious, this is how Emperor looks under IE: |
Looks pretty, thank you @jacksonchen |
It is indeed really pretty! |
…t appears when WebGL is disbled.
Build results will soon be (or already are) available at: http://ci.qiime.org/job/emperor-github-pr/124/ |
Fantastic, thank you very much for the changes @jacksonchen!! |
Fixes #165 by displaying an info box if WebGL is not detected
Displays an info box if WebGL is not detected (#165). The info box contains information on how to enable WebGL on three browsers: Chrome, Safari, and Firefox.