Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #165 by displaying an info box if WebGL is not detected #186

Merged
merged 4 commits into from
Sep 21, 2013

Conversation

jacksonchen
Copy link
Contributor

Displays an info box if WebGL is not detected (#165). The info box contains information on how to enable WebGL on three browsers: Chrome, Safari, and Firefox.

@ghost
Copy link

ghost commented Sep 16, 2013

Build results will soon be (or already are) available at: http://ci.qiime.org/job/emperor-github-pr/114/

@ElDeveloper
Copy link
Member

Thanks for adding this, this is exactly one of the things that we needed the most!

I think this should not show the sidebar and in turn should only show a white background with this message at the center. It would also make sense to add a small explanation of what is happening, something along the lines of: "Emperor's visualization framework is WebGL based, it seems that your system doesn't have this resource available ... etc ".

Some suggestions:

  • Add some formatting to highlight the name of the browsers (maybe bold fonts or maybe small icons).
  • Maybe adding the emperor logo somewhere?

@ElDeveloper
Copy link
Member

An extra addition to this is to mention that if you are using chrome and still not seeing an image, go to chrome://flags and then look to enable Override software rendering. Obviously this will be specific for chrome but it's worth noting.

…lso updated to include a logo and more text.
@ghost
Copy link

ghost commented Sep 19, 2013

Build results will soon be (or already are) available at: http://ci.qiime.org/job/emperor-github-pr/122/

@ElDeveloper
Copy link
Member

Woooow! This looks really pretty!!! Thanks much @jacksonchen.

Just a couple suggestions:

  • Disable it if you haven't already -> Disable this option if you haven't already.
  • look to enable Override software rendering -> search for "Override software rendering list and enable this option".
  • Open Safari menu and select Preferences. Click on the advanced tab, and then check Show Develop menu. Then open the Develop menu and select Enable WebGL. -> Open Safari's menu and select Preferences. Click on the advanced tab, and then check "Show Developer" menu. Then open the "Developer" menu and select "Enable WebGL".
  • Title and main explanation should be centered (as they currently are) but the rest of the text should be set as justify.
  • If there's a source for this information we should cite it.
  • Make the font a little bigger, perhaps just overall 2 points or 3 bigger.

After this, it should be ready to merge.

@jacksonchen
Copy link
Contributor Author

Thanks for the feedback! I added your suggestions and here is the commit. Hopefully it is in the final form to be merged, thanks!

@ghost
Copy link

ghost commented Sep 19, 2013

Build results will soon be (or already are) available at: http://ci.qiime.org/job/emperor-github-pr/123/

@ElDeveloper
Copy link
Member

Hello @jacksonchen I think this is it. @antgonza suggested I tested this on IE, it of course didn't work and the error message was presented, so this is working great! The two things that I'm going to suggest are to:

  • Mention these are the only browsers supported.
  • Mention to reload the pages once they have gone through these changes.

If people is curious, this is how Emperor looks under IE:

captura de pantalla 2013-09-20 a la s 09 23 53

@antgonza
Copy link
Collaborator

Looks pretty, thank you @jacksonchen

@ElDeveloper
Copy link
Member

It is indeed really pretty!

@ghost
Copy link

ghost commented Sep 20, 2013

Build results will soon be (or already are) available at: http://ci.qiime.org/job/emperor-github-pr/124/

@ElDeveloper
Copy link
Member

Fantastic, thank you very much for the changes @jacksonchen!!

ElDeveloper added a commit that referenced this pull request Sep 21, 2013
Fixes #165 by displaying an info box if WebGL is not detected
@ElDeveloper ElDeveloper merged commit 11e1db4 into biocore:master Sep 21, 2013
@jacksonchen jacksonchen deleted the issue_165 branch September 21, 2013 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants