Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Use Github actions as a new CI system. #4482

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Conversation

JakaKokosar
Copy link
Member

@JakaKokosar JakaKokosar commented Mar 2, 2020

Issue
Experimentally use Github actions as a new CI system.

Description of changes
Run new CI alongside Travis and Appveyor to test how it behaves.

Known downsides:

Update: Previous running jobs are cancelled if a new commit is pushed to the same PR 👍

Github action is not as feature reach as other systems because it was released not long ago. So I noticed that currently there is no officially supported way to cancel "stale" commits in a certain branch. Potentially this could be a problem. I hope there will soon be support for this. For now, we could use some third-party solutions that use Github public APIs (did not test those yet).
https://gh.neting.ccmunity/t5/GitHub-Actions/Github-actions-Cancel-redundant-builds/td-p/29549

To see running job go here: https://github.com/biolab/orange3/actions

Linux job (ubuntu 18.04):

To-do:

  • Complete tests with codecoverage (linux)
  • Run tests on Windows and MacOS (tests that need database support will be skipped.)
  • Pylint
  • Documentation build check

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #4482 into master will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4482      +/-   ##
==========================================
+ Coverage   83.26%   83.64%   +0.37%     
==========================================
  Files         274      279       +5     
  Lines       54851    59180    +4329     
==========================================
+ Hits        45671    49500    +3829     
- Misses       9180     9680     +500

@JakaKokosar JakaKokosar force-pushed the github_actions branch 18 times, most recently from bd21706 to 3eff45d Compare March 2, 2020 22:18
@JakaKokosar JakaKokosar changed the title [WIP] Use Github actions as out new CI system. [WIP] Use Github actions as a new CI system. Mar 2, 2020
@JakaKokosar JakaKokosar force-pushed the github_actions branch 3 times, most recently from caf0c6e to cede898 Compare March 4, 2020 08:43
@JakaKokosar JakaKokosar force-pushed the github_actions branch 20 times, most recently from d11d11c to ca44032 Compare March 4, 2020 19:54
@JakaKokosar JakaKokosar changed the title [WIP] Use Github actions as a new CI system. Use Github actions as a new CI system. Mar 11, 2020
@JakaKokosar JakaKokosar changed the title Use Github actions as a new CI system. [ENH] Use Github actions as a new CI system. Mar 11, 2020
@markotoplak
Copy link
Member

This PR already proved its usefulness: OSX tests are failing since merging #4443. They also fail locally for me and @JakaKokosar.

@markotoplak markotoplak merged commit bd5778e into master Mar 11, 2020
@markotoplak markotoplak deleted the github_actions branch March 11, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants