[ENH] Add row side color annotations #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
heatmaps-grid-widget
branch
2 times, most recently
from
a8e38fd
to
b339c5d
Compare
Codecov Report
@@ Coverage Diff @@
## master #4443 +/- ##
==========================================
+ Coverage 83.13% 83.24% +0.11%
==========================================
Files 268 274 +6
Lines 53916 54807 +891
==========================================
+ Hits 44821 45625 +804
- Misses 9095 9182 +87 |
ales-erjavec
force-pushed
the
heatmaps-grid-widget
branch
6 times, most recently
from
f60ee58
to
d1c5962
Compare
|
SimpleLayoutItem is not so simple anymore
... capabilities
Use current contents size as the basis
Use TextListWidget with autoScale param
The grid layout cannot satisfy both hdfw and wfh constraints, the existing solution of using/focing current actual width as an estimate for size hint cannot work and causes repeated relayouts ad infinitum.
ales-erjavec
force-pushed
the
heatmaps-grid-widget
branch
from
d1c5962
to
8793f53
Compare
ales-erjavec
force-pushed
the
heatmaps-grid-widget
branch
from
8793f53
to
ec36fa5
Compare
|
It seems fine now. |
|
I have noticed that on heatmaps that are larger than the canvas the annotations are cut from the canvas (one can not scroll far enough to reach them). |
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref gh-4380
Add color row annotations to the 'Heatmap' widget.
Description of changes
Includes