Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] heatmap: Ensure minimim size for color annotations #4519

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

ales-erjavec
Copy link
Contributor

Issue

Ref: #4443 (comment)

Description of changes

Ensure minimum width on the color annotations.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4fd0a48). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #4519   +/-   ##
=========================================
  Coverage          ?   83.26%           
=========================================
  Files             ?      274           
  Lines             ?    54852           
  Branches          ?        0           
=========================================
  Hits              ?    45672           
  Misses            ?     9180           
  Partials          ?        0           

@markotoplak
Copy link
Member

@ales-erjavec, since #4443 I also get a test failure on Macs:

Traceback (most recent call last):
  File "/Users/marko/dev/orange3/Orange/widgets/utils/tests/test_graphicstextlist.py", line 55, in test_alignment
    self.assertEqual(brect(item).bottom(), 100)
AssertionError: 100.703125 != 100

@Hrovatin
Copy link
Contributor

The annotation is now visible (although the numbers in the legend is marginally cut off).
Screenshot from 2020-03-13 11-22-40

@lanzagar
Copy link
Contributor

Unless @ales-erjavec would like to try anything else regarding the right margin, I think we can merge this as is...

@lanzagar lanzagar merged commit da9d536 into biolab:master Mar 20, 2020
@ales-erjavec ales-erjavec deleted the heatmap-color-min-size branch August 5, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants