feat(lint): useCollapsedElseIf #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
n-gude
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Conaclos
requested changes
Sep 5, 2023
crates/rome_js_analyze/src/analyzers/nursery/use_collapsed_else_if.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/use_collapsed_else_if.rs
Outdated
Show resolved
Hide resolved
fix: comment detection, feat: differentiate between safe and suggested code fix
n-gude
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Conaclos
requested changes
Sep 5, 2023
crates/rome_js_analyze/src/analyzers/nursery/use_collapsed_else_if.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/use_collapsed_else_if.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/use_collapsed_else_if.rs
Outdated
Show resolved
Hide resolved
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Conaclos
approved these changes
Sep 6, 2023
|
Thanks! Great contribution :) I had to change the description of the rule: it caused a fail when the website is bundled (this seems to be a bug of Astro). |
Conaclos
added
the
S-Needs-changelog-update
|
I have to thank for accepting my first PR! 🙌 Cool to already see it in action in the playground! The issue (#43) is still open. Can be closed, right? |
|
@n-gude This is a great first contribution! Looking forward for your future ones :) |
Conaclos
removed
the
S-Needs-changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the
useCollapsedElseIflint rule (#43).It provides a code fix unless the else-block statement contains a comment. The placement of the comment would be questionable. (ESLint handles it the same way.)
Test Plan
Tests included.