feat(lint): useCollapsedIf JS lint rule #4179
Merged
+1,534
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
github-actions
bot
added
A-CLI
siketyan
changed the title
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
CodSpeed Performance ReportMerging #4179 will improve performances by 18.61%Comparing Summary
Benchmarks breakdown
|
togami2864
reviewed
Oct 5, 2024
| @@ -0,0 +1,81 @@ | |||
| /** | |||
There was a problem hiding this comment.
Could you check the original test file and add cases to increase coverage?
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/test/no-lonely-if.mjs
| @@ -0,0 +1,18 @@ | |||
| if (condition && anotherCondition) { | |||
There was a problem hiding this comment.
ditto. Please check the test file.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/test/no-lonely-if.mjs
siketyan
commented
Oct 6, 2024
crates/biome_js_analyze/tests/specs/nursery/useCollapsedIf/invalid.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
# Conflicts: # crates/biome_configuration/src/analyzer/linter/rules.rs
siketyan
force-pushed
the
feat/useCollapsedIf
branch
from
806cee3
to
63dd21e
Compare
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
Conaclos
reviewed
Oct 7, 2024
…eck the expr needs parens Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
# Conflicts: # crates/biome_configuration/src/analyzer/linter/rules.rs
Conaclos
reviewed
Oct 7, 2024
# Conflicts: # crates/biome_configuration/src/analyzer/linter/rules.rs # crates/biome_js_analyze/src/lint/nursery.rs # packages/@biomejs/backend-jsonrpc/src/workspace.ts # packages/@biomejs/biome/configuration_schema.json
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
siketyan
force-pushed
the
feat/useCollapsedIf
branch
from
8556077
to
68c6810
Compare
|
@togami2864 @Conaclos |
Conaclos
approved these changes
Oct 14, 2024
togami2864
approved these changes
Oct 16, 2024
siketyan
force-pushed
the
feat/useCollapsedIf
branch
2 times, most recently
from
bc81ebf
to
ac9ff95
Compare
siketyan
force-pushed
the
feat/useCollapsedIf
branch
from
ac9ff95
to
0847315
Compare
|
@togami2864 Merged main branch and re-run |
Conaclos
pushed a commit
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3944
This pull requests adds
useCollapsedIfrule that suggests to merge two nestedifstatements into one if the parent has only one statement and the child has no else clauses.The implementation is largely based on
useCollapsedElseIf(#160).This is my first time to make changes to Biome, so please let me know if missing something to do. 🙏
Test Plan
See test snapshots.