This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
Implements Face to Face payment method #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqrrm
approved these changes
Jul 22, 2018
| @Override | ||
| public String getPaymentDetailsForTradePopup() { | ||
| // We don't show here more as the makers extra data are the relevant for the trade. City has to be anyway the | ||
| // same for maker and taker. |
There was a problem hiding this comment.
While it's true that the city has to be the same it might just be nice to have that confirmation that you're in the right city in case multiple f2f have been set up.
ripcurlx
approved these changes
Jul 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Face to Face payment method
This is a very basic version without any of the advanced features discussed at bisq-network/proposals#24
It assumes that both traders carry their laptop to the meeting.
We could start with that and see how much interest it creates.
If positive we can add support for the mobile support as discussed here:
bisq-network/proposals#24 (comment)
Screenshots:
bisq-network/proposals#24 (comment)
Depends on:
bisq-network/bisq-common#30