-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Face to Face payment method #1607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Did a test trade and everything looks fine. Not sure if the link in the docs will be a top level anchor in https://docs.bisq.network or if it will be just a link to an additional document under the https://docs.bisq.network/#features group. @cbeams what's your take on the link structure?
@ripcurlx I think the text for the F2F trade rules, suggestions, guide will be quite a bit, so I think a dedicated page might be worth for it. But leave it to @cbeams where he thinks it fits best. We can also use a global referrer link (e.g. f2f.bisq.network or bisq.network/f2f) and then forward where ever it should be.... |
At https://docs.bisq.network/, there's an entry in the index that reads:
This doc has not yet been written, but would take what's in the FAQ and elsewhere about the rules of trading and arbitration, and would locate them in a single, first-class doc with the URL https://docs.bisq.network/rules.html. By default, I would want to keep the F2F rules in the same doc (one stop shopping), at e.g. https://docs.bisq.network/rules.html#face-to-face-trading. If the F2F content is too long, and swamps the rest of the document, then we could do a separate rules-f2f.html doc. Hopefully not necessary, though. In any case, it would be a good time to write the rules doc. IIRC, @ManfredKarrer, you and @m52go discussed this elsewhere recently. Steve, are you interested in writing that? I can help direct you to the stuff that is already documented, and can be available for Q&A / review along the way. |
Yup. Agree that it makes sense to keep them together in 1 doc. I'll take a closer look when I get back near a computer in the next 4-5 days. |
In this intended F2F version, |
@HarryMacfinned In the current version we just use the normal Bisq trade protocol, so yes BTC is required. If F2F gets some traction we might evolve and add a off-chain trade protocol and then there are no restrictions on BTC anymore (but likely on BSQ). |
Implements Face to Face payment method
This is a very basic version without any of the advanced features discussed at bisq-network/proposals#24
It assumes that both traders carry their laptop to the meeting.
We could start with that and see how much interest it creates.
If positive we can add support for the mobile support as discussed here:
bisq-network/proposals#24 (comment)
Screenshots:
bisq-network/proposals#24 (comment)
Depends on:
bisq-network/bisq-common#30
bisq-network/bisq-core#138