Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guidelines #3762

Closed

Conversation

freimair
Copy link
Contributor

@freimair freimair commented Dec 8, 2019

This is another step towards a more streamlined reviewing process and making better use of the resources we have. These changes are largely based on a recent maintainers call.

Key points of the re-design:

  • added a "Are you the guy?" section. Let people know up front what they can expect.
  • added a "getting started" section. Link (updated) communication channels, describe how to get going.
  • refactored the rest:
    • refined some parts in order to make them more clear
    • added bits that might streamline the maintenance process of Bisq (testing, PR ttl, further reading)

Once this gets approved, I will schedule a dev-call on this very topic to get into the points a little more.

@freimair freimair requested a review from ripcurlx December 8, 2019 13:03
@freimair freimair changed the title Update contribution guidelines [WIP] Update contribution guidelines Dec 9, 2019
@freimair freimair marked this pull request as ready for review December 9, 2019 10:50
@freimair freimair force-pushed the update_contribution_guidelines branch from ef9035e to 9145a18 Compare December 9, 2019 12:44
Refactored the stuff that has already been there and added the
bits and peaces according to a recent call.
added youtube links
@freimair freimair force-pushed the update_contribution_guidelines branch from 9145a18 to aaa3307 Compare December 9, 2019 12:57
@freimair freimair changed the title [WIP] Update contribution guidelines Update contribution guidelines Dec 9, 2019
@ripcurlx ripcurlx requested a review from cbeams December 10, 2019 09:22
@ripcurlx
Copy link
Contributor

@cbeams Would be great to get your input on this, especially as a native speaker 😄

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

I think the content we want to have in is there, but I'd like for more regular contributors to respond as this is a bigger change in our PR process as well.

@sqrrm @cbeams @julianknutsen @wiz @devinbileck @chimp1984

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@julianknutsen julianknutsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments inline. I tried not to go too far in the weeds with the feedback I've already shared with my onboarding experience. Happy to take another look for more structure/grammar issues once a few more people weigh in.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@devinbileck
Copy link
Member

Overall this seems like good content to include and I agree with the feedback provided thus far. Some of the wording and terminology could be improved. @m52go would you be able to have a look at this?

@freimair
Copy link
Contributor Author

that is a first. Changing the CONTIBUTING.md broke the build with jdk12. Does master still build?

Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freimair, I just had a moment to review this today, so haven't done a comprehensive job. If you can fold in the current batch of feedback, I'll commit to giving the doc a proper editing pass when you're done.

@stale
Copy link

stale bot commented Jan 19, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jan 19, 2020
@freimair
Copy link
Contributor Author

will do

@stale
Copy link

stale bot commented Feb 19, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Feb 19, 2020
@stale
Copy link

stale bot commented Feb 27, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this Feb 27, 2020
@ripcurlx ripcurlx reopened this Feb 27, 2020
@stale stale bot removed the was:dropped label Feb 27, 2020
@freimair freimair requested review from ripcurlx and cbeams February 27, 2020 11:33
@stale
Copy link

stale bot commented Mar 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 29, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 29, 2020
@stale
Copy link

stale bot commented May 6, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants