-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contribution guidelines #3762
Update contribution guidelines #3762
Conversation
ef9035e
to
9145a18
Compare
Refactored the stuff that has already been there and added the bits and peaces according to a recent call.
added youtube links
9145a18
to
aaa3307
Compare
@cbeams Would be great to get your input on this, especially as a native speaker 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
I think the content we want to have in is there, but I'd like for more regular contributors to respond as this is a bigger change in our PR process as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments inline. I tried not to go too far in the weeds with the feedback I've already shared with my onboarding experience. Happy to take another look for more structure/grammar issues once a few more people weigh in.
Overall this seems like good content to include and I agree with the feedback provided thus far. Some of the wording and terminology could be improved. @m52go would you be able to have a look at this? |
that is a first. Changing the CONTIBUTING.md broke the build with jdk12. Does master still build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@freimair, I just had a moment to review this today, so haven't done a comprehensive job. If you can fold in the current batch of feedback, I'll commit to giving the doc a proper editing pass when you're done.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
will do |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant. |
This is another step towards a more streamlined reviewing process and making better use of the resources we have. These changes are largely based on a recent maintainers call.
Key points of the re-design:
Once this gets approved, I will schedule a dev-call on this very topic to get into the points a little more.