Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 18 #685

Closed
freimair opened this issue Oct 20, 2020 · 16 comments
Closed

For Cycle 18 #685

freimair opened this issue Oct 20, 2020 · 16 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:rejected Indicates that a compensation request was rejected by DAO voting
Milestone

Comments

@freimair
Copy link

freimair commented Oct 20, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 3603
  • USD requested: 2450
  • BSQ rate: 0.68 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 17 #655

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Monitoring Operator/Maintainer ops* 200 bisq-network/roles#10 (comment)
Establish network usage metrics dev 2250 bisq-network/projects#13 (comment)

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Update contribution guidlines security 150 bisq-network/bisq#3762
Tor v3 Milestone "Allow old clients to update" dev 4350 bisq-network/bisq#3044
Create more detailed offer book metrics dev 750 bisq-network/projects#22
Add code coverage reports to Codacy security 300 bisq-network/bisq#4454
Reduce bandwidth requirement on Bisq startup dev 3200 bisq-network/projects#25 the project got completed recently, and given the design is the design I came up with, I claim compensation for the feasibility study, the proof of concept implementation (bisq-network/bisq#4233), and some overhead
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:ops https://bisq.wiki/Ops_Team team:dev https://bisq.wiki/Dev_Team labels Oct 20, 2020
@MwithM MwithM added this to the Cycle 18 milestone Oct 20, 2020
@chimp1984
Copy link

chimp1984 commented Oct 21, 2020

The 3200 USD for bisq-network/projects#25 seems a bit high to me. Consider also the lost effort which went into your implementation from various reviewers. For not merged code there is usually no compensation. As the concept was good and was used as base for the final implementation as well as your code base (though that got transformed to a huge extent) I agree that we should compensate your efforts for that project. Thought the amount seems too high to me.

@ripcurlx
Copy link
Contributor

The 3200 USD for bisq-network/projects#25 seems a bit high to me. Consider also the lost effort which went into your implementation from various reviewers. For not merged code there is usually no compensation. As the concept was good and was used as base for the final implementation as well as your code base (though that got transformed to a huge extent) I agree that we should compensate your efforts for that project. Thought the amount seems too high to me.

@freimair Could you please respond to this comment as I haven't reviewed the PR in discussion? Thanks!

@freimair
Copy link
Author

freimair commented Oct 28, 2020

though that got transformed to a huge extent

I disagree. Yes, coding style changed a lot, yes, the "version" information has its own protocol field now, and yes, stuff only applies to TradeStatistics now. But overall, the business logic did not change too much and I could have made these changes with very little efforts based on my ready-to-ship PR. However, the project was defined as is half a year ago (by a group of people) I was not aware of the new requirements. You pretty much took a finished solution and refactored it - can be seen clearly because your first PR bisq-network/bisq#4519 has been solely based on all my code. Also consider, that sq, aka the reviewer, and I had in-depth discussions on how stuff works and that it is a big and risky step. The reviewer therefore knew the concept of the PR already, and hence, did not have to invest too much time into thinking through a whole new PR. Please note that I did not ask for compensation for testing, because you took the liberty to delete all tests.

For not merged code there is usually no compensation.

That kind-of changed with the rise of the projects concept. Projects have been introduced to reduce the risk of big changes not being compensated and thus, encourage more people to do bigger projects and thus, really improve Bisq. Unfortunately, since the project concept has been introduced, pretty much only I adopted the process for non-management projects and only 2 projects got closed (the KPIs and bisq-network/projects#25) so far.

The 3200 USD for bisq-network/projects#25 seems a bit high to me.

For making Bisq work again? I disagree. (details: because slow inet, i.e. tor, speed means Bisq cannot be used and we only have around 450 active nodes at each time, loosing more would not benefit the project - keep in mind that we already might have lost lots of users because of these issues). And the project has been priced at a discount to begin with and I only ask for roughly half of it anyways.

@chimp1984
Copy link

We both have the right to disagree. So will I.

@freimair
Copy link
Author

freimair commented Oct 29, 2020

I understand that your vote will make my compensation request fail if I do not lower the amount for the project in question, so I will include that part in my next compensation request. Maybe you care about naming an amount you are comfortable with?

@ripcurlx
Copy link
Contributor

Based on the changes mentioned in #685 (comment) as stand in team lead I approve this request for dev now.

@freimair
Copy link
Author

@wiz can I have your two cents here as well?

@chimp1984
Copy link

@freimair I think 50% of the initial request amount for that project is justified.

@wiz
Copy link

wiz commented Oct 30, 2020

It's fine but I thought @Emzy was taking over the Bisq monitor since you resigned? Are you guys still coordinating that?

@freimair
Copy link
Author

b3d5225b03c0e1477934e08cf19bf4f30a03d495eb5d6e06ecec7fe67c8120bc

@chimp1984
Copy link

@freimair Can you please provide @Emzy the necessary information/data for the monitor setup (grafana config,...). Please check in all the data required to get a running monitor into a repo (can you yours) so its easier to share and transparent. I consider that as part of the monitor project the DAO has paid for and expect that the handover works without much hassle. Thanks in advance.

@chimp1984
Copy link

chimp1984 commented Nov 4, 2020

@freimair
As you have not reacted I will wait with supporting your request until you have fulfilled the outstanding obligation to provide the source of work you got paid for. The current monitor project is incomplete as it misses the Grafana setup as well as potentially other tools used. I consider the monitor project complete when a dev can run it from the provided source and instructions on his own and get the same end result. This should have been done from day one on when you started to use Grafana. We are an open source project and by default all produced work has to be made open source and available for others to get the same result.

I will support your open request once that handover is completed with the amount requested here + 50% of the "initial data request" amount you inititally requested.

@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 5, 2020

Based on the changes mentioned in #685 (comment) as stand in team lead I approve this request for dev now.

Based on the unresponsiveness on the missing handover of the items required to run the monitor I have to withdraw my approval for this compensation request this cycle.

@MwithM MwithM added the was:rejected Indicates that a compensation request was rejected by DAO voting label Nov 8, 2020
@MwithM
Copy link
Contributor

MwithM commented Nov 8, 2020

Closed as rejected.

@MwithM MwithM closed this as completed Nov 8, 2020
@chimp1984
Copy link

@freimair As stated above please provide all data and information to @Emzy so that he can start to setup the monitor and we can do the handover.

The DAO has invested about 50 000 USD in the monitor project and we need to ensure that this investment does not vanish just because you left the project. To re-do all the work to setup Grafana would be too much of an effort to invest again into the project with quite limited value (it never fulfilled the purpose to be an alert system). If you don't provide the needed information to reduce the needed effort for the handover I consider that investment as a huge loss for Bisq. Holding back work you got paid for is not acceptable.

My support for your outstanding requests is directly depending on that outstanding delivery.

Also be assured I have not been the only one who rejected your request.

@freimair freimair mentioned this issue Nov 10, 2020
@xanoni
Copy link

xanoni commented Sep 26, 2021

This is still a problem ... the website links to a broken monitor ....

See bisq-network/bisq#5297 (comment)

xanoni added a commit to xanoni/bisq-website that referenced this issue Sep 26, 2021
Commented out the monitor for now given it's been broken for a year or
so, which could be wrongly interpreted as "Bisq itself has problems".

Files affected: _data/*.yml

See:
- bisq-network/bisq#5297 (comment)
- bisq-network/bisq#5340
- bisq-network/compensation#685 (comment)
xanoni added a commit to xanoni/bisq-website that referenced this issue Sep 28, 2021
Commented out the "monitor" site link for now, given it's been broken for a year or
so, which could be wrongly interpreted as "Bisq itself has problems".

Files affected: _layouts/page_stats.html

See (non-exhaustive list of related discussions):
- bisq-network/bisq#5297 (comment)
- bisq-network/bisq#5340
- bisq-network/compensation#685 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:rejected Indicates that a compensation request was rejected by DAO voting
Projects
Archived in project
Development

No branches or pull requests

6 participants