Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PriceNode: exclude currencies via config #5582

Merged
merged 2 commits into from Jul 13, 2021
Merged

PriceNode: exclude currencies via config #5582

merged 2 commits into from Jul 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2021

This allows the PriceNode to configure certain currencies as not quoted, i.e. will not be delivered in its service API. By doing so, those markets can self-discover the price the same way as is already done in BSQ/BTC market.

Fixes #5581

Config

Added to application.properties

bisq.price.fiatcurrency.excluded=LBP,ARS
bisq.price.cryptocurrency.excluded=

Code changes:

  • get Environment object from Spring framework.
  • parse & validate any currencies specified in the application.properties file.
  • exclude currencies from the exchange supported fiat currency / crypto currency lists.
  • log details of currencies excluded via configuration.
  • add tests for the above.

@ripcurlx ripcurlx added this to the v1.7.1 milestone Jul 6, 2021
@ripcurlx
Copy link
Contributor

@jmacxx It does work as described on RegTest, but what is the difference to using fixed price right now already?

Current state:
Bildschirmfoto 2021-07-13 um 10 02 28

Filtered out state:
Bildschirmfoto 2021-07-13 um 09 58 12

So the only difference is that as a user I have the price of the last trade as indicator what someone was willing to pay.

@ghost
Copy link
Author

ghost commented Jul 13, 2021

When a market is quoted by a price feed, users are limited to trading at prices within 50% of the reference quote. If we disable the quote for LBP & ARS the user can trade using the street price.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Tested it on Regtest. The changes for these market should be coordinated with @pazza83 I guess.

@ripcurlx ripcurlx merged commit dddabe3 into bisq-network:master Jul 13, 2021
@pazza83
Copy link

pazza83 commented Jul 18, 2021

I will test it with the new release. I also think it is worth promoting to potential users in these markets.

@ghost ghost mentioned this pull request Jul 18, 2021
@ghost ghost deleted the pricenode_config_ccy_excl branch May 29, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users in Argentina and Lebanon unable to use Bisq
3 participants