Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricenode: configurable exclusion by provider currency #6227

Merged
merged 2 commits into from May 30, 2022
Merged

Pricenode: configurable exclusion by provider currency #6227

merged 2 commits into from May 30, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 27, 2022

The provider exchange Huobi has added BRL with an inaccurate rate such that users have noticed and complained that the Bisq index rate for BRL is wrong.

This PR adds the ability to exclude a currency feed from a specific provider, such that we can ignore the bad BRL rate from Huobi. In essence it is a follow-on from #5582 which allowed global currency exclusions; this is a provider level exclusion.

@Emzy would you be ok to try out this PR?


Config

Added to application.properties. This is the suggested value to fix the Huobi issue:

bisq.price.fiatcurrency.excludedByProvider=HUOBI:BRL

Multiple providers can have exclusions, and more than one ccy can be excluded as follows (a comma separated list of items in the format PROVIDER_NAME:CCY)

bisq.price.fiatcurrency.excludedByProvider=HUOBI:BRL,HUOBI:GBP,BINANCE:SEK,BINANCE:AUD

@ghost
Copy link
Author

ghost commented May 28, 2022

Added commit 0310958 at request of @Emzy, to completely remove Huobi as a provider. This is because they started feeding a bad EUR rate, 40% below other providers. So without Huobi we'll not currently need to exclude by provider currency, but the feature can still be useful in the future. The application.properties setting will do no harm referencing a non-existent provider -- it can remain as indication of how the feature can be used.

@Emzy
Copy link
Contributor

Emzy commented May 28, 2022

I'm running this pr on my Pricenode right now. Because of a very wrong EUR price from Huobi this is necessary for now.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.9.2 milestone May 30, 2022
@ripcurlx ripcurlx merged commit a0e73d7 into bisq-network:master May 30, 2022
@ghost ghost mentioned this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants