Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve clickable areas of toggle buttons #6307

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

Android-X13
Copy link
Contributor

Fixes #6263

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 31, 2022

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

ghost
ghost previously approved these changes Aug 9, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghost
Copy link

ghost commented Aug 13, 2022

@Android-X13 looks great. May I request an additional thing?
Could you fix the clickable area of toggle buttons in DAO -> Facts & Figures -> Bsq Supply screen? There its possible to click on a toggle button and it toggles the one below.

image

@Android-X13
Copy link
Contributor Author

Hi @jmacxx,
The author of the relevant code resorted to a hack in order to decrease the height of the switches and the vertical gap between them:

switch hack

The switches work best in their default height although the gaps increase quite enough which isn't what was wanted.
Unless there's a better way to shrink the toggle's height symmetrically instead of doing hacks, my only solution to this would be to decrease the overlapping between them. But this would mean that their vertical gaps would increase a bit. And the clickable area still won't be ideal (but it will be better than now).
If you still want this, should I push it in this branch?

@ghost
Copy link

ghost commented Aug 14, 2022

the clickable area still won't be ideal (but it will be better than now).

Yes, I think an improvement would be worth it. To my mind it is similar enough to include in this branch. Thanks.

@Android-X13
Copy link
Contributor Author

Before:

Before

After:

After

The clickabe area is better now and the vertical distance between the switches isn't increased (too) much.
It could be better but the gaps would also grow more.. I think the compromise between height and clickable areas is acceptable now

@Android-X13 Android-X13 changed the title Fix clickable area of Enable Offers toggle button Fix/improve clickable areas of toggle buttons Aug 14, 2022
@Android-X13 Android-X13 reopened this Aug 15, 2022
@Android-X13
Copy link
Contributor Author

Kindly disregard my ramblings in the last comment above. The vertical gaps between toggles in BSQ SUPPLY do increase like shown, but their clickable area is ideal now.

Also, somehow I managed to screw up this PR. Really sorry about that. I'm new to git...

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #6307 (review)

@ripcurlx ripcurlx added this to the v1.9.5 milestone Aug 17, 2022
@ripcurlx ripcurlx merged commit ad92129 into bisq-network:master Aug 17, 2022
@ghost ghost mentioned this pull request Sep 5, 2022
@Android-X13 Android-X13 deleted the fix-issue-6263 branch September 20, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Offers toggle-button activated when not clicking it
2 participants