-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/improve clickable areas of toggle buttons #6307
Conversation
Thanks for opening this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@Android-X13 looks great. May I request an additional thing? |
Hi @jmacxx, The switches work best in their default height although the gaps increase quite enough which isn't what was wanted. |
Yes, I think an improvement would be worth it. To my mind it is similar enough to include in this branch. Thanks. |
5424104
to
169aca1
Compare
Kindly disregard my ramblings in the last comment above. The vertical gaps between toggles in BSQ SUPPLY do increase like shown, but their clickable area is ideal now. Also, somehow I managed to screw up this PR. Really sorry about that. I'm new to git... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - based on #6307 (review)
Fixes #6263