Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 39 #1152

Closed
Android-X13 opened this issue Sep 8, 2022 · 3 comments
Closed

For Cycle 39 #1152

Android-X13 opened this issue Sep 8, 2022 · 3 comments
Assignees
@ripcurlx
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:not submitted Indicates that a compensation request was not submitted for DAO voting
Milestone
Cycle 39

Comments

@Android-X13
Copy link

Summary

  • BSQ requested: 201
  • USD requested: 175
  • BSQ rate: 0.87 USD per BSQ
  • Previous compensation request (if applicable): #

Contributions delivered

Title Team USD Link Notes
Fix/improve clickable areas of toggle buttons dev 45 bisq-network/bisq/pull/6307
Show Peer Info window only when left-clicking on avatar dev 25 bisq-network/bisq/pull/6309
Cleanup blockchain explorer URL code & add tests dev 60 bisq-network/bisq/pull/6319
Fix NPE when accessing DAO > BSQ SUPPLY dev 45 bisq-network/bisq/pull/6323

Contributions in progress

Fix issue with offers getting disabled for no apparent reason
Prevent NPE when editing offer while not fully connected
Refresh all avatars upon setting a peer's tag
Prevent NPE in Open Proposals when last column is empty
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Sep 8, 2022
@Android-X13
Copy link
Author

This is my first CR and I have just realized that there are deadlines announced in the compensation repo... I see that the deadline has been reached but people are still submitting CRs so I made this one too.

One question:
Since the total amount requested is relatively low, can I bring this to the next cycle or do I have to submit it to the DAO?

@MwithM
Copy link
Contributor

MwithM commented Sep 9, 2022 •
edited
Loading

I would prefer if you wait for next cycle to submit it. Indeed, that's the only choice you have right now, as the DAO proposal phase has concluded.
I leave it open for review, though, so it can be pre-approved by the team lead.

You'll have to use the BSQ rates for Cycle 40, while maintain the same USD amounts.

@MwithM MwithM added this to the Cycle 39 milestone Sep 9, 2022
@MwithM MwithM added the was:not submitted Indicates that a compensation request was not submitted for DAO voting label Sep 17, 2022
@MwithM
Copy link
Contributor

MwithM commented Sep 17, 2022

Closed as not submitted.

@MwithM MwithM closed this as completed Sep 17, 2022
@Android-X13 Android-X13 mentioned this issue Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:not submitted Indicates that a compensation request was not submitted for DAO voting
Projects
Compensation Request Board
Archived in project
Milestone
Cycle 39
Development

No branches or pull requests
3 participants
@ripcurlx @MwithM @Android-X13