Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when accessing DAO > BSQ SUPPLY #6323

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

Android-X13
Copy link
Contributor

Fixes #6187

To reproduce:
Upon startup of the application, switch between the various DAO sections and their inner tabs to/from FACTS & FIGURES > BSQ SUPPLY. This may or may not throw an NPE.
It usually does for me, and most often it can be traced to bsqTradeFeeAmountProperty or seriesSupplyChange being set to null.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
I've never managed to reproduce that NPE, must be missing the magic touch.
utACK, ran ok.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #6323 (review)

@ripcurlx ripcurlx added this to the v1.9.5 milestone Aug 17, 2022
@ripcurlx ripcurlx merged commit a3f2a99 into bisq-network:master Aug 17, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 17, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when accessing DAO->BSQ Supply
2 participants