-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API call to get DAO status #7012
Conversation
Just wanted to point out, there seams to be no call rate metering. |
I have applied the changes on top of v1.9.14 and currently using the new gRPC method. Everything working well!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
getdaostatus
is missing in the /bisq-cli --help
output.
Should rate metering be included as well? bisq/daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java Lines 401 to 426 in 8dda8b2
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Tested:
bisq-cli --help
bisq-cli getdaostatus --help
bisq-cli getdaostatus
- Rate Limiting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Expose
DaoFacade.isDaoStateReadyAndInSync
status to API clients.